Add tp_richcompare handler for Imaging_Type/ImagingCore #7260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Jul 5, 2023
Member
|
Valgrind is currently failing - https://github.com/python-pillow/Pillow/actions/runs/5460694184/jobs/9937936242?pr=7260 Also, I went to test the speed of image equality with this, radarhere@98e02aa... and found https://github.com/radarhere/Pillow/actions/runs/5461893489/jobs/9940492884#step:8:4787
|
Contributor
Author
|
oops, Py_NewRef wasn't added until Python 3.10. |
radarhere
reviewed
Jul 6, 2023
homm
reviewed
Jul 6, 2023
homm
reviewed
Jul 7, 2023
This was referenced Jul 11, 2023
radarhere
reviewed
Oct 6, 2023
radarhere
reviewed
Oct 7, 2023
radarhere
reviewed
Oct 7, 2023
radarhere
reviewed
Oct 7, 2023
Closed
Yay295
force-pushed
the
image_equals
branch
2 times, most recently
from
bbf5370 to
7eba51c
Compare
Yay295
force-pushed
the
image_equals
branch
2 times, most recently
from
0e86ed9 to
17faca4
Compare
Yay295
force-pushed
the
image_equals
branch
2 times, most recently
from
1f8077d to
d8012b3
Compare
Yay295
force-pushed
the
image_equals
branch
from
f481c3c to
97a08ff
Compare
Yay295
force-pushed
the
image_equals
branch
from
ff49d68 to
5322aaa
Compare
Py_True and Py_False were only made immortal in Python 3.12, so we have to properly increment their refcount for versions before that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imaging_Type/ImagingCore is exposed by Image.getdata(), so this allows you to properly compare the result of that method without it being an identity comparison. This should also speed up comparison between Image objects, because now the comparison is done in C instead of passing the data back to Python for it to be compared.