Skip to content

Fix differing background colors in right sidebar in dark mode docs #5515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 3 commits into from
Jun 12, 2021
Merged

Fix differing background colors in right sidebar in dark mode docs #5515

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaa2d6a
fix differing background colors in right sidebar [ci skip]
PH-KDX May 28, 2021
0a609d7
Removed duplicate block
radarhere May 28, 2021
544ecdb
Merge pull request #1 from radarhere/css
PH-KDX May 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions docs/resources/css/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1275,7 +1275,7 @@

.wy-body-for-nav {
background-image: initial;
background-color: rgb(26, 28, 29);
background-color: rgb(24, 26, 27);
Copy link
Member

@radarhere radarhere May 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you come up with this new value?

Copy link
Contributor Author

@PH-KDX PH-KDX May 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it from the bottom half with Inspect Element; it also has a better contrast with the main text block. Several members of the Python Discord helped decide on it.

}

.wy-nav-side {
Expand Down Expand Up @@ -1333,11 +1333,6 @@
color: rgb(152, 143, 129);
}

.wy-body-for-nav {
background-image: initial;
background-color: rgb(26, 28, 29);
}

@media screen and (min-width: 1100px) {
.wy-nav-content-wrap {
background-image: initial;
Expand Down