Fix differing background colors in right sidebar in dark mode docs #5515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
changed the title
Removed duplicate block
radarhere
reviewed
May 30, 2021
| .wy-body-for-nav { | ||
| background-image: initial; | ||
| background-color: rgb(26, 28, 29); | ||
| background-color: rgb(24, 26, 27); |
Member
There was a problem hiding this comment.
How did you come up with this new value?
Contributor
Author
There was a problem hiding this comment.
Got it from the bottom half with Inspect Element; it also has a better contrast with the main text block. Several members of the Python Discord helped decide on it.
Contributor
Author
|
What's the current status on this? |
Member
|
The current status is... merged! Thanks for the PR! |
Contributor
Author
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes differently colored blocks in the right sidebar in the dark mode docs.
For comparison, see the following two images:
Before fix (current situation):
After fix:
Change proposed in this pull request:
background-colorof the top part of the right sidebar in the docs darker when in dark mode to match the rest of the right sidebar