Skip to content

Forward --no-color to the rich.Console instance #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2024
Merged

Forward --no-color to the rich.Console instance #11048

merged 3 commits into from
Jul 9, 2024

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Apr 19, 2022

Closes #11045

@q0w q0w marked this pull request as draft April 19, 2022 21:39
@q0w q0w force-pushed the no-color branch 2 times, most recently from 7115790 to 484c1b6 Compare April 19, 2022 22:16
@uranusjr uranusjr changed the title Modify global rich.Console instance Forward --no-color to the rich.Console isntance Apr 19, 2022
@uranusjr uranusjr changed the title Forward --no-color to the rich.Console isntance Forward --no-color to the rich.Console instance Apr 19, 2022
@q0w q0w marked this pull request as ready for review April 20, 2022 19:02
@q0w q0w mentioned this pull request Jun 8, 2022
Open
@ichard26 ichard26 requested a review from pradyunsg April 22, 2024 21:33
@ichard26 ichard26 added this to the 24.2 milestone Jun 23, 2024
@pradyunsg pradyunsg merged commit f0bb386 into pypa:main Jul 9, 2024
@pradyunsg
Copy link
Member

Thanks as always @q0w! ^.^

@q0w q0w deleted the no-color branch July 10, 2024 03:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@pradyunsg pradyunsg Awaiting requested review from pradyunsg

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.

--no-color not respected by download progress bar output
4 participants
@q0w @pradyunsg @uranusjr @ichard26