--no-color not respected by download progress bar output

[matsaman]

Description

--no-color not respected by download progress bar output

Expected behavior

No response

pip version

22.0.4

Python version

3.9.12

OS

macOS

How to Reproduce

pip install numpy --no-cache-dir --no-color, for example, produces color.

Output

No response

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[q0w]

what about adding no_color flag to _rich_progress_bar and rich.reconfigure console?

[matsaman]

NO_COLOR=foo pip install numpy --no-cache-dir does disable the color, therefore it does appear to be Rich at issue as you've suspected. Ideally I'd say we'd want to control its color output through the existing --no-color option.

[q0w]

The problem is here

progress = Progress(*columns, refresh_per_second=30)

and rich.get_console() returns new console instance. Maybe move rich.Console initialization somewhere outside setup_logging?

[gdlmx]

After almost one year, this issue is still not fixed. A workaround is using the NO_COLOR environment variable, which inject the setting into rich.console.Console.