Skip to content

requirements: bump twine to ~= 6.0 - #309

Merged
webknjaz merged 1 commit into
pypa:unstable/v1from
trail-of-forks:ww/bumptwine
Dec 4, 2024
Merged

requirements: bump twine to ~= 6.0#309
webknjaz merged 1 commit into
pypa:unstable/v1from
trail-of-forks:ww/bumptwine

Conversation

@woodruffw

Copy link
Copy Markdown
Member

The locked requirements now resolve 6.0.1.

Closes #308.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw

Copy link
Copy Markdown
Member Author

@webknjaz Could you give this a peek when you get a chance? I suspect a lot of Maturin-based builds are going to begin to run into issues here, like we're seeing here: https://github.com/trailofbits/rfc3161-client/actions/runs/12122650623/job/33796528057

termoshtt added a commit to Jij-Inc/ommx that referenced this pull request Dec 4, 2024
- Use twine 5.1.1 for validating wheels until
pypa/gh-action-pypi-publish#309 is merged.
- twine 5.1.1 does not supports metadata 2.4, thus fix `maturin ==
1.7.5` since it uses metadata 2.4 until 1.7.6
PyO3/maturin#2335
@davidhewitt

Copy link
Copy Markdown

If I can also please add my request for this to be reviewed: due to an unfortunate bug in PyO3 0.23 there will probably be a lot of builds in the coming days to release new versions of Rust / maturin based projects without corrupted wheels.

It would be helpful if this could be merged so all those projects don't have to go through a dance pinning back maturin / twine / this action. Thanks in advance 🙏

@webknjaz
webknjaz merged commit e7723a4 into pypa:unstable/v1 Dec 4, 2024
@webknjaz

webknjaz commented Dec 4, 2024

Copy link
Copy Markdown
Member

@woodruffw thanks! I hope I'll get to releasing this today.

@samuelcolvin

Copy link
Copy Markdown

Thanks so much @webknjaz.

@davidhewitt

Copy link
Copy Markdown

Thanks! 🎉

@cdump

cdump commented Dec 5, 2024

Copy link
Copy Markdown

Hi. Looks like twine upgrade is not enough, tested on whl build with pyo3/maturin 0.23.3
unstable-v1 image hash = 83623c34c365

$ podman run -v `pwd`:/mnt --entrypoint /bin/bash --rm -it ghcr.io/pypa/gh-action-pypi-publish:unstable-v1

root@910b2e56a188:/app# twine --version
twine version 6.0.1 (keyring: 25.2.1, pkginfo: 1.10.0, requests: 2.32.3, requests-toolbelt: 1.0.0,
urllib3: 2.2.1)

root@910b2e56a188:/app# twine check /mnt/*.whl
Checking /mnt/evmole-0.6.1-cp310-cp310-macosx_10_12_x86_64.macosx_11_0_arm64.macosx_10_12_universal2.whl: ERROR    InvalidDistribution: Metadata is missing required fields: Name, Version.
         Make sure the distribution includes the files where those fields are specified, and is using a
         supported Metadata-Version: 1.0, 1.1, 1.2, 2.0, 2.1, 2.2, 2.3.


root@910b2e56a188:/app# pip3 install pkginfo --upgrade
..
Successfully installed pkginfo-1.12.0

root@910b2e56a188:/app# twine check /mnt/*.whl
Checking /mnt/evmole-0.6.1-cp310-cp310-macosx_10_12_x86_64.macosx_11_0_arm64.macosx_10_12_universal2.whl: PASSED

#310

Comment thread requirements/runtime.in
@@ -1,4 +1,4 @@
twine
twine ~= 6.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that we didn't really need to cap this below v7 since this input file is not used w/o the constraints anyway: 67339c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update requirements lock to use twine v6

5 participants