Skip to content

Bump maturin, pyo3, add free-threaded 3.13t wheel - #47

Merged
oconnor663 merged 7 commits into
oconnor663:masterfrom
ddelange:maturin-bump
Dec 5, 2024
Merged

Bump maturin, pyo3, add free-threaded 3.13t wheel#47
oconnor663 merged 7 commits into
oconnor663:masterfrom
ddelange:maturin-bump

Conversation

@ddelange

@ddelange ddelange commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

ready for review but still need to bump version after release of gh-action-pypi-publish ^

@ddelange

ddelange commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator Author

cc @oconnor663

@ddelange

ddelange commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator Author

hmm, looks like the fix for windows 3.13 no longer works? PyO3/maturin-action#292 (comment)

regardless of 3.13 / 3.13t

@davidhewitt

Copy link
Copy Markdown

does it work if you enable PyO3's generate-import-lib feature? 🤔

@davidhewitt

Copy link
Copy Markdown

It looks to me like the lib path is missing for some reason, can you use PYO3_PRINT_CONFIG=1 env with just --interpreter 3.13? Might give us some hints...

@ddelange

ddelange commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator Author

@davidhewitt

  -- PYO3_PRINT_CONFIG=1 is set, printing configuration and halting compile --
  implementation=CPython
  version=3.13
  shared=true
  abi3=false
  lib_name=python313
  lib_dir=C:\hostedtoolcache\windows\Python\3.13.0\x64\libs
  executable=C:\hostedtoolcache\windows\Python\3.13.0\x64\python.exe
  pointer_width=64
  build_flags=
  suppress_build_script_link_lines=false

@ddelange

ddelange commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator Author

@davidhewitt looks like adding generate-import-lib worked! Can you explain what happened here?

@davidhewitt

Copy link
Copy Markdown

Great! The generate-import-lib feature allows PyO3 to do exactly that - produce the library shim to link against instead of requiring one.

As to why the original library was not present, I'm not sure. I can try to debug that another time.

@ddelange
ddelange marked this pull request as ready for review December 4, 2024 15:57
@oconnor663

Copy link
Copy Markdown
Owner

@ddelange thanks for being so on top of this stuff. At this point you're doing more to maintain the project than I am. I'm going to go ahead and make you a repo maintainer. If I ever go a few months without reviewing PRs again, I trust you to do what you think is best :)

@oconnor663
oconnor663 merged commit 217473b into oconnor663:master Dec 5, 2024
@ddelange

ddelange commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

@oconnor663 awesome, thanks for the trust and looking forward to collaborating!

now watching all activity!

https://http.cat/202

P.S. soon you'll see a small PR incoming to bump gh-action-pypi-publish as soon as they release (also watching that one)

@ddelange

ddelange commented Dec 6, 2024

Copy link
Copy Markdown
Collaborator Author

awaiting upstrean release: maturin is now included in their CI 🎉

pypa/gh-action-pypi-publish#313

@ddelange

ddelange commented Dec 24, 2024

Copy link
Copy Markdown
Collaborator Author

hi @davidhewitt 👋

this error is back on main, despite generate-import-lib now being present. any ideas?

edit: fixed in #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants