Skip to content

Narwhals support for CLV aggregation #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Jul 3, 2025

Description

Still a work in progress.

The LazyFrame like libraries will require a provided observation_end_date. However, that can be found outside of the

Still building out the functionality for the:

  • remove first observation - mean with nans might differ in the backends

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1809.org.readthedocs.build/en/1809/

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (ca0c420) to head (f4804c8).

Files with missing lines Patch % Lines
pymc_marketing/clv/utils.py 26.31% 14 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ca0c420) and HEAD (f4804c8). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (ca0c420) HEAD (f4804c8)
22 13
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1809       +/-   ##
===========================================
- Coverage   92.28%   40.45%   -51.84%     
===========================================
  Files          62       62               
  Lines        7469     7487       +18     
===========================================
- Hits         6893     3029     -3864     
- Misses        576     4458     +3882     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanitorduz
Copy link
Collaborator

OMG! 100% yes! 🥳

@ColtAllen
Copy link
Collaborator

ColtAllen commented Jul 15, 2025

OMG! 100% yes! 🥳

Indeed, thanks for starting this!

Do you think the current pandas functions should still be retained for a time even after this is merged? Also, it seems like the PR description in the original message requires more details.

@williambdean
Copy link
Contributor Author

Do you think the current pandas functions should still be retained for a time even after this is merged? Also, it seems like the PR description in the original message requires more details.

I was just doing some comparisons of the two at the moment. However, I think that the new one should just take it's place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants