Support sorted shuffle write in Sapphire-Velox stack#24739
Merged
facebook-github-bot merged 1 commit intoApr 22, 2025
Conversation
|
|
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Mar 17, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
3e2bece to
4a8d2ba
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Mar 17, 2025
Summary: Pull Request resolved: prestodb#24739 Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
4a8d2ba to
398080a
Compare
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Mar 20, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
398080a to
0de03de
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
force-pushed
the
export-D71236519
branch
from
0de03de to
91767da
Compare
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Mar 24, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Mar 24, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
91767da to
df68805
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
Contributor
|
Hi @emilysun201309, would you sign the Presto CLA? The information to do so is in this earlier comment. |
emilysun201309
force-pushed
the
export-D71236519
branch
from
df68805 to
428adea
Compare
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 3, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 3, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
428adea to
6e85f34
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 3, 2025
Summary: Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
6e85f34 to
c431913
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 3, 2025
Summary: Pull Request resolved: prestodb#24739 Support sorted shuffle write in Sapphire-Velox stack: - Copy the key value serializer: `fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.h` from Spruce to `github/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.h` This is so that we don't have dependency on the internal implementation. - Allow PartitionAndSerialize Node to take `sortingOrder and `sortingKeys` as optional parameters. - If both `sortingOrder and `sortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key. Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
c431913 to
09c7604
Compare
emilysun201309
force-pushed
the
export-D71236519
branch
from
c26ab6f to
43dde56
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
1 similar comment
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 11, 2025
Summary: Pull Request resolved: prestodb#24739 To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
43dde56 to
68e9cb9
Compare
xiaoxmeng
approved these changes
Apr 16, 2025
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 16, 2025
Summary: To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
68e9cb9 to
7550692
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 21, 2025
Summary: To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
7550692 to
2e6c7a5
Compare
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 21, 2025
Summary: To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
2e6c7a5 to
3317aea
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
1 similar comment
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 21, 2025
Summary: Pull Request resolved: prestodb#24739 To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
3317aea to
855fab9
Compare
Contributor
Author
|
/easycla |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 22, 2025
Summary: To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
855fab9 to
551c719
Compare
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 22, 2025
Summary: To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
emilysun201309
force-pushed
the
export-D71236519
branch
from
551c719 to
3a76011
Compare
Summary: Pull Request resolved: prestodb#24739 To later support sorted shuffle in Sapphire-Velox, we need to have a way to serializer sort keys, so that they are binary sortable. This diff creates a BinarySortableSerializer. - BinarySortableSerializer is based on Hive's BinarySortableSerDe - The implementation is borrowed from the CoscoKeyValueSerializer from Spruce. - Create a copy of the above in presto-trunk this is so that we don't have dependency on the internal implementation. - Add benchmarks in BinarySortableSerializerBenchmark.cpp Reviewed By: xiaoxmeng Differential Revision: D71236519
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
1 similar comment
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D71236519 |
emilysun201309
force-pushed
the
export-D71236519
branch
from
3a76011 to
694355d
Compare
21 tasks
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Support sorted shuffle write in Sapphire-Velox stack:
Copy the key value serializer:
fbcode/spark_cpp/src/main/serializer/CoscoKeyValueSerializer.hfrom Spruce togithub/presto-trunk/presto-native-execution/presto_cpp/main/operators/KeyValueSerializer.hThis is so that we don't have dependency on the internal implementation.
Allow PartitionAndSerialize Node to take
sortingOrder andsortingKeys` as optional parameters.If both
sortingOrder andsortingKeys` are provided, serialize the Keys and invoke Cosco sorted shuffle by providing an non-empty key.Differential Revision: D71236519