Modify handling of no-bids in Krux Link adapter #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Sep 15, 2016
src/adapters/kruxlink.js
Outdated
| } | ||
|
|
||
| // Add any no-bids remaining | ||
| for (var placementCode in placements) { |
Contributor
There was a problem hiding this comment.
Please rename placementCode here to impId as that is what it is (and most likely which caused the error in the first place). Thanks!
Contributor
Author
There was a problem hiding this comment.
Can do, making the update now
Contributor
|
LGTM. THanks! |
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 23, 2016
…3.0 to master * commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits) Added support for new adapters introduced in 0.13.0 into AOL analytics Updated CHANGELOG Fixed merge conflict Prebid 0.13.0 Release Resolves prebid#635 (prebid#640) Add IX Deal Support (prebid#638) Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641) added timeouts to rubicon adapter that consider time-to-start costs (prebid#629) Modify handling of no-bids in Krux Link adapter (prebid#628) Allow bypassing ajax preflights with config options (prebid#630) validateIndentation: Invalid indentation character (prebid#631) use `splice` rather than `slice` to remove bids from array (prebid#637) delete the callback before calling clearAuction (prebid#636) Deal override fix to resolve prebid#618 (prebid#619) Update package.json Video - create mastertagUrl from adservertag (prebid#614) Prevent renderAd from rendering videos (prebid#623) Remove unused build depencencies (prebid#622) Add pull request template (prebid#615) Openx adaptor deal update (prebid#612) ...
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Modify handling of no-bids in Krux Link adapter * Modify handling of no-bids in Krux Link adapter
pm-abhinav-deshpande
pushed a commit
to pm-abhinav-deshpande/Prebid.js
that referenced
this pull request
Apr 23, 2025
…308174035 Prebid upgarde automate- test pull request created through git api please ignore it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Modifies handling of the case when no bid is returned from the Krux Link API.
[email protected]
Other information
@sethyates, please review