Skip to content

Conversation

@matthewlane
Copy link
Collaborator

@matthewlane matthewlane commented Sep 13, 2016

Type of change

  • Build related changes

Description of change

package.json contains devDependencies that aren't used in the project. This PR removes some of those. To test after checking out this branch, use npm prune or remove node_modules and reinstall with npm install. It may be helpful to take a checksum of build/dist/prebid.js before and after building with the different sets of dependencies to verify that the output file isn't affected.

@mkendall07 mkendall07 self-assigned this Sep 13, 2016
@mkendall07
Copy link
Contributor

LGTM.

@mkendall07 mkendall07 merged commit f91fd4c into master Sep 14, 2016
@mkendall07 mkendall07 deleted the remove-unused-dependencies branch September 14, 2016 15:21
marian-r added a commit to aol/Prebid.js that referenced this pull request Sep 23, 2016
…3.0 to master

* commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits)
  Added support for new adapters introduced in 0.13.0 into AOL analytics
  Updated CHANGELOG
  Fixed merge conflict
  Prebid 0.13.0 Release
  Resolves prebid#635 (prebid#640)
  Add IX Deal Support (prebid#638)
  Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641)
  added timeouts to rubicon adapter that consider time-to-start costs (prebid#629)
  Modify handling of no-bids in Krux Link adapter (prebid#628)
  Allow bypassing ajax preflights with config options (prebid#630)
  validateIndentation: Invalid indentation character (prebid#631)
  use `splice` rather than `slice` to remove bids from array (prebid#637)
  delete the callback before calling clearAuction (prebid#636)
  Deal override fix to resolve prebid#618 (prebid#619)
  Update package.json
  Video - create mastertagUrl from adservertag (prebid#614)
  Prevent renderAd from rendering videos (prebid#623)
  Remove unused build depencencies (prebid#622)
  Add pull request template (prebid#615)
  Openx adaptor deal update (prebid#612)
  ...
Studnicky pushed a commit to sonobi/Prebid.js that referenced this pull request Oct 4, 2016
pm-abhinav-deshpande pushed a commit to pm-abhinav-deshpande/Prebid.js that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants