Skip to content

Conversation

@EYHN
Copy link
Contributor

@EYHN EYHN commented Jul 23, 2025

Trying to fix #34338

@peppy peppy self-requested a review July 24, 2025 03:15
peppy
peppy previously approved these changes Jul 24, 2025
@EYHN
Copy link
Contributor Author

EYHN commented Jul 24, 2025

@peppy This will break your original fix f086be9 and cause the SongContinuesAfterExitPlayer test to fail.

@peppy
Copy link
Member

peppy commented Jul 24, 2025

@peppy This will break your original fix f086be9 and cause the SongContinuesAfterExitPlayer test to fail.

was half expecting that. i'll have to reassess, since the code doesn't match expectations / previous versions.

@peppy peppy self-requested a review July 24, 2025 04:19
@peppy peppy force-pushed the eyhn/fix/present-preview-point branch from 6222fa5 to 07137f3 Compare July 24, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Go to beatmap" doesn't play from preview point when pressed in main menu

3 participants