-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty #34227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
peppy
merged 1 commit into
ppy:master
from
bdach:display-weird-numbers-for-mania-so-that-people-stop-complaining
Jul 16, 2025
Merged
Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty #34227
peppy
merged 1 commit into
ppy:master
from
bdach:display-weird-numbers-for-mania-so-that-people-stop-complaining
Jul 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… application on overall difficulty In stable mania, Hard Rock and Easy mods do not work the same way as they do on all of the rulesets. The difference is that mania HR and EZ, rather than apply a multiplier to the map's original Overall Difficulty, apply multipliers to *the durations of hit windows themselves*. Prior to the last release, lazer was oblivious to this reality and just treated mania HR / EZ as it did every other ruleset. Last release, for the sake for gameplay parity across rulesets, the mods in question were adjusted to match stable, but in the process, it started looking like HR / EZ did not change OD anymore. The problem is that they do, but applying a multiplier to the map's OD and applying a multiplier to the hit window duration is not the same thing. The second thing is actually *much harsher* in magnitude, to the point where applying HR to any map is almost guaranteed to exceed "the effective OD" of 10, and applying EZ to any map is almost guaranteed to result in "negative effective OD". This change attempts to convey that reality by displaying "effective OD", similar to what's already done in other rulesets when rate-changing mods are active. Note that the values this will display *do not match* stable *and that is correct*, because stable song select *lies* about the actual impact on OD by just assuming it can treat all rulesets in the same way. --- Would close ppy#34150 I guess. And yes I would like *all of the above* to land on the changelog if possible if this is merged. For further convincing that this makes any semblance of sense please see the following: https://www.desmos.com/calculator/yigt7jycdv
83e5956 to
131f828
Compare
Member
|
Here's an attempted reword of the public message attached to this change which I think reads a bit better for end users: Feel free to diff at your end and apply as you see fit. |
Collaborator
Author
|
Have applied. |
peppy
approved these changes
Jul 16, 2025
Member
peppy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me
This was referenced Aug 27, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:difficulty
area:song-select
size/L
type/cosmetic
Only affects the game visually. Doesn't affect things working or not working.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In osu!stable's osu!mania implementation, "Hard Rock" and "Easy" mods do not work the same way as they do on all other rulesets. Rather than applying a multiplier to the map's base Overall Difficulty value, it applies multipliers to the durations of hit windows themselves.
Applying a multiplier to the map's OD instead of the hit windows is not the same thing. The second thing is actually much harsher in magnitude, to the point where applying HR to any map is almost guaranteed to exceed "the effective OD" of 10, and applying EZ to any map is almost guaranteed to result in "negative effective OD".
Prior to the last release, osu!lazer was oblivious to this reality and just treated mania HR / EZ as it did every other ruleset. Last release, for the sake for gameplay parity across rulesets, the mods in question were adjusted to match stable, but in the process, it made it look on the surface like HR / EZ were not changing OD anymore.
In actuality, the hit windows were still being adjusted (now matching stable), but this was no longer visible in the OD displayed at song select.
This change attempts to convey that reality by displaying "effective OD", similar to what's already done in other rulesets when rate-changing mods are active. Note that the values this will display do not match stable and that is correct, because stable song select lies about the actual impact on OD by just assuming it can treat all rulesets in the same way.
Would close #34150 I guess.
And yes I would like all of the above to land on the changelog if possible if this is merged.
For further convincing that this makes any semblance of sense please see the following: https://www.desmos.com/calculator/yigt7jycdv
Citation for stable just lying about the OD. Also note that stable just lies about DT/HT affecting OD on mania as well although it doesn't quantify by how much because it only shows a down/up triangle.