This repository was archived by the owner on Jun 4, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 72
Issue 840 - Fix proptypes & syntax highlighting, and improve tests #841
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f980e4c
- fix proptypes
1f7ca98
changelog
a327fe8
changelog
78c4db3
check for errors only
99126ba
move tests/integration -> tests/selenium and standardize
d9aeb3c
update highlight.js usage
558d216
PreventUpdate instead of None
7584d3d
fix log error - assets/logo.png instead of external url
9e80289
log errors, check for empty array instead (to see error content in py…
ef60484
add highlights julia support
511a217
add syntax highlight test
d80ea9a
add plaintext
e6a4d47
changelog
9540802
latest highlight.js
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -183,68 +183,10 @@ jobs: | |
npm run lint | ||
when: always | ||
|
||
|
||
"python-3.6": | ||
docker: | ||
- image: circleci/python:3.7.5-stretch-node-browsers | ||
|
||
environment: | ||
PERCY_ENABLED: True | ||
PERCY_PROJECT: plotly/dash-table-python-v0 | ||
|
||
steps: | ||
- checkout | ||
|
||
- run: | ||
name: Inject Percy Environment variables | ||
command: | | ||
echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV | ||
|
||
- run: | ||
name: Install requirements | ||
command: | | ||
sudo pip install --upgrade virtualenv | ||
python -m venv venv || virtualenv venv | ||
. venv/bin/activate | ||
pip install -r dev-requirements.txt --quiet | ||
npm ci | ||
|
||
- run: | ||
name: Install dependencies (dash) | ||
command: | | ||
. venv/bin/activate | ||
git clone --depth 1 [email protected]:plotly/dash.git dash-main | ||
pip install -e ./dash-main[dev,testing] --quiet | ||
cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../.. | ||
|
||
- run: | ||
name: Install test requirements | ||
command: | | ||
. venv/bin/activate | ||
npm run build | ||
python setup.py sdist | ||
cd dist | ||
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd .. | ||
|
||
- run: | ||
name: ⚙️ run integration test | ||
command: | | ||
. venv/bin/activate | ||
pytest --junitxml=test-reports/dash.xml tests/integration | ||
- store_artifacts: | ||
path: test-reports | ||
- store_test_results: | ||
path: test-reports | ||
- store_artifacts: | ||
path: /tmp/dash_artifacts | ||
|
||
|
||
|
||
workflows: | ||
version: 2 | ||
build: | ||
jobs: | ||
- "python-3.6" | ||
- "node" | ||
- "server-test" | ||
- "standalone-test" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to upgrade highlight in DCC too while this is front of mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. And if tacking that on, might as well add Julia support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plotly/dash-core-components#871