Issue 840 - Fix proptypes & syntax highlighting, and improve tests #841
Conversation
- add logs check in tests
|
Removing Py3.6 tests - interesting... I guess there's an argument that components only need to test with the latest Python, as they have no independent Python code, and in the main dash repo we create test components and test them against multiple Python versions, verifying that the generated code will all work across versions. That said table has some Python helper functions for formatting, which it would be nice to test will work across versions. On the other hand how much longer are we even going to support Py2, which would be the main reason for such a test? So in the end I'd say yeah, this is fine. |
| @@ -1,4 +1,4 @@ | |||
| import highlightjs from 'highlight.js/lib/highlight'; | |||
| import highlightjs from 'highlight.js/lib/core'; | |||
There was a problem hiding this comment.
Want to upgrade highlight in DCC too while this is front of mind?
There was a problem hiding this comment.
Sure. And if tacking that on, might as well add Julia support.
There was a problem hiding this comment.
| @@ -85,6 +85,7 @@ def test_tbcp001_copy_paste_callback(test): | |||
|
|
|||
| assert target.cell(1, 0).get_text() == "0" | |||
| assert target.cell(1, 1).get_text() == "MODIFIED" | |||
| assert len(test.get_log_errors()) == 0 | |||
There was a problem hiding this comment.
| assert len(test.get_log_errors()) == 0 | |
| assert test.get_log_errors() == [] |
That way if it fails you see what the error was
There was a problem hiding this comment.
Good point 9e80289
|
For #841 (comment) - the formatter tests are currently run with the unit tests, on py37 only. The py36 tests are a misnomer as all that job really did was (1) load two apps with table/graph and take a screenshot of them, (2) run some export tests. Tests in (1) don't really test anything, tests in (2) were moved with the other e2e tests. |
Marc-Andre-Rivet
changed the title
Closes #840
tests/integrationtests withtests/seleniumtests using the newer fixture / patternpython-3.6CI job (to be removed on approval) andpercy/dash-table-python-v0(those two visual tests have been flaky since forever and never uncovered a bug anyway)As part of improving the tests, found an additional regression breaking
highlight.jsafter #814 -- this does not affectdccas it uses9.xand the usage there is correct.