Implement #65038: IMAGETYPE_WEBP constant missing #2157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add WebP support for getimagesize(), getimagesizefromstring)(), image_type_to_extension() and image_type_to_mime_type(). For now we care only about the simple lossy WebP format (VP8) and ignore the lossless (VP8L) and extended (VP8X) formats. We use image/webp as MIME type as it appears to be pretty common, even though it is not yet registered with IANA. Relevant specifications: * <https://developers.google.com/speed/webp/docs/riff_container> * <https://tools.ietf.org/html/rfc6386>
|
Should be fine to commit to master, @dshafik might have some comments for 7.1, but its fairly small and self contained so tbh it should be just fine |
|
I'm fine with this in 7.1 |
|
Thanks! I'll merge ASAP. |
|
Applied as 14d4ee9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add WebP support for getimagesize(), getimagesizefromstring)(),
image_type_to_extension() and image_type_to_mime_type(). For now we
care only about the simple lossy WebP format (VP8) and ignore the
lossless (VP8L) and extended (VP8X) formats. We use image/webp as MIME
type as it appears to be pretty common, even though it is not yet
registered with IANA.
Relevant specifications: