Added support for WebP #85
Conversation
lib/ImageResize.php
Outdated
| @@ -62,6 +63,10 @@ public static function createFromString($image_data) | |||
| */ | |||
| public function __construct($filename) | |||
| { | |||
| if(!defined('IMAGETYPE_WEBP')) { | |||
There was a problem hiding this comment.
More info: https://bugs.php.net/bug.php?id=65038 and php/php-src#2157
|
Why update PHP version? It is possible to detect version and raise exception in < 5.5 version if WebP is not available. Please make such changes and I will merge. We don't have stats for number of users of this library who is using PHP 5.3. |
* Removed surpress warnings for 'getimagesize' and 'exif_read_data' * added check whether file/stream exists and is an image * added check whether exif data isset * added error messages * updated and added tests for new error handling * added test ressource for xmp exif which can not be read by 'exif_read_data'
I made a little change to prevent bad use of quality
I made a little mistake, now quality is ok
|
@adityapatadia done |
|
@adityapatadia can you review this? |
|
I already reviewed. I asked for a clarification on line. Please check this: https://github.com/eventviva/php-image-resize/pull/85/files/cd5d24c898a5df4e2f8ddb1e466100ac517da919#diff-f240e336d3a2b05f788f3e68cad2555bR138 |
|
Also, if possible please create new PR with fresh branch. This one got stale. |
|
Can you please check above? I will merge as soon as issues are resolved. |
|
Yep, sorry for delay.
I'll check it in 1-2 days
On Sun, Sep 3, 2017, 22:28 Aditya Patadia ***@***.***> wrote:
Can you please check above? I will merge as soon as issues are resolved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADRO98Z4T_6_9XQGvZ8pkDc2xgh58_P1ks5sev3jgaJpZM4OQMGM>
.
--
Best regards,
Nikita Chernyi, Backend Developer, DevOps.
rakshazi.cf
|
|
Sure, will be waiting. |
|
@adityapatadia created new PR #91 |
Required PHP>= 5.5.0 (EOL in middle 2016), current oldstable is 5.6.x.
I think, you can update requirements in
composer.json