Skip to content

CLN: use with instead of try finally in io/stata.py #38326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2020
Merged

CLN: use with instead of try finally in io/stata.py #38326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
644f80e
CLN: use with instead of try finally in io/stata.py
Dec 6, 2020
bed5d8c
Merge remote-tracking branch 'upstream/master' into use-with-stata
Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pandas/io/stata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1912,11 +1912,8 @@ def read_stata(
if iterator or chunksize:
return reader

try:
data = reader.read()
finally:
reader.close()
return data
with reader:
return reader.read()


def _set_endianness(endianness: str) -> str:
Expand Down