Skip to content

CLN: use with instead of try finally in io/stata.py #38326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2020
Merged

CLN: use with instead of try finally in io/stata.py #38326

merged 2 commits into from
Dec 8, 2020

Conversation

fangchenli
Copy link
Member

This is reported by lgtm.com.

@jreback
Copy link
Contributor

jreback commented Dec 8, 2020

hmm do you know why lgtm is reporting this? this is a context manager, maybe not picking it up somehow?

cc @twoertwein

@jreback jreback added Code Style Code style, linting, code_checks IO Stata read_stata, to_stata labels Dec 8, 2020
@twoertwein
Copy link
Member

thank you, looks good!

@jreback jreback added this to the 1.3 milestone Dec 8, 2020
@jreback
Copy link
Contributor

jreback commented Dec 8, 2020

sorry i was looking at the old. thanks @fangchenli

@jreback jreback merged commit 1ba3f3c into pandas-dev:master Dec 8, 2020
@fangchenli fangchenli deleted the use-with-stata branch November 18, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks IO Stata read_stata, to_stata
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fangchenli @jreback @twoertwein