perf(linter/plugins): remove code for renaming global values #16610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-performance
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a workaround in the TypeScript plugin code that was previously needed to rename misspelled global values from "writeable" to "writable". After PR #16609 fixed the serialization in the Rust code (using #[serde(rename_all = "lowercase")] on the GlobalValue enum), the JSON now correctly contains "writable" instead of "writeable", making this TypeScript workaround obsolete.
Key Changes
- Removed the loop that renamed "writeable" to "writable" in deserialized globals
- Simplified control flow by using if-else instead of early return pattern
- Removed unused
Writabletype import fromtype-fest - Enhanced debug assertions to include array type check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
changed the base branch from
12-08-refactor_linter_rename_globalvalue_writeable_to_writable_
to
graphite-base/16610
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
"Writeable" is a mis-spelling. In addition: Oxlint docs say: > You may also use `"writeable"` or `true` to represent `"writable"`. [ESLint's docs](https://eslint.org/docs/v8.x/use/configure/language-options#using-configuration-files-1) state "writable" (without an "e") as the name of the option. This suggests that "writable" is the "real" name of this option, and "writeable" (with an "e") is an alias provided for backwards compat. Therefore, I think it makes more sense to call the enum variant `GlobalValue::Writable` (with the correct spelling). Main motivation is that it means globals get serialized with the right spelling, allowing removing a JS-side workaround from JS plugins code (#16610). For consistency, I've changed "writeable" to "writable" in all test cases, except for 1 test which specifically aims to check that that "legacy" spelling is accepted. https://github.com/oxc-project/oxc/blob/00c5614d1f1bb3465ba7aa5ad668a936b8ec1266/crates/oxc_linter/src/config/globals.rs#L161-L168
graphite-app
bot
force-pushed
the
graphite-base/16610
branch
from
00c5614 to
913b1b3
Compare
graphite-app
bot
force-pushed
the
12-08-perf_linter_plugins_remove_code_for_renaming_global_values
branch
from
4f65b42 to
74641bb
Compare
graphite-app
bot
force-pushed
the
12-08-perf_linter_plugins_remove_code_for_renaming_global_values
branch
from
74641bb to
91d17e3
Compare
camc314
approved these changes
Dec 8, 2025
Contributor
Merge activity
|
After #16609, the value of globals is serialized correctly ("writable" not "writeable"), so this workaround is no longer required. Remove it.
graphite-app
bot
force-pushed
the
12-08-perf_linter_plugins_remove_code_for_renaming_global_values
branch
from
91d17e3 to
0241b9a
Compare
graphite-app
bot
deleted the
12-08-perf_linter_plugins_remove_code_for_renaming_global_values
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
"Writeable" is a mis-spelling. In addition: Oxlint docs say: > You may also use `"writeable"` or `true` to represent `"writable"`. [ESLint's docs](https://eslint.org/docs/v8.x/use/configure/language-options#using-configuration-files-1) state "writable" (without an "e") as the name of the option. This suggests that "writable" is the "real" name of this option, and "writeable" (with an "e") is an alias provided for backwards compat. Therefore, I think it makes more sense to call the enum variant `GlobalValue::Writable` (with the correct spelling). Main motivation is that it means globals get serialized with the right spelling, allowing removing a JS-side workaround from JS plugins code (#16610). For consistency, I've changed "writeable" to "writable" in all test cases, except for 1 test which specifically aims to check that that "legacy" spelling is accepted. https://github.com/oxc-project/oxc/blob/00c5614d1f1bb3465ba7aa5ad668a936b8ec1266/crates/oxc_linter/src/config/globals.rs#L161-L168
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
After #16609, the value of globals is serialized correctly ("writable" not "writeable"), so this workaround is no longer required. Remove it.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…project#16609) "Writeable" is a mis-spelling. In addition: Oxlint docs say: > You may also use `"writeable"` or `true` to represent `"writable"`. [ESLint's docs](https://eslint.org/docs/v8.x/use/configure/language-options#using-configuration-files-1) state "writable" (without an "e") as the name of the option. This suggests that "writable" is the "real" name of this option, and "writeable" (with an "e") is an alias provided for backwards compat. Therefore, I think it makes more sense to call the enum variant `GlobalValue::Writable` (with the correct spelling). Main motivation is that it means globals get serialized with the right spelling, allowing removing a JS-side workaround from JS plugins code (oxc-project#16610). For consistency, I've changed "writeable" to "writable" in all test cases, except for 1 test which specifically aims to check that that "legacy" spelling is accepted. https://github.com/oxc-project/oxc/blob/00c5614d1f1bb3465ba7aa5ad668a936b8ec1266/crates/oxc_linter/src/config/globals.rs#L161-L168
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ject#16610) After oxc-project#16609, the value of globals is serialized correctly ("writable" not "writeable"), so this workaround is no longer required. Remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #16609, the value of globals is serialized correctly ("writable" not "writeable"), so this workaround is no longer required. Remove it.