refactor(linter): rename GlobalValue::Writeable to Writable

[overlookmotel]

"Writeable" is a mis-spelling. In addition:

Oxlint docs say:

You may also use "writeable" or true to represent "writable".

ESLint's docs state "writable" (without an "e") as the name of the option.

This suggests that "writable" is the "real" name of this option, and "writeable" (with an "e") is an alias provided for backwards compat.

Therefore, I think it makes more sense to call the enum variant GlobalValue::Writable (with the correct spelling).

Main motivation is that it means globals get serialized with the right spelling, allowing removing a JS-side workaround from JS plugins code (#16610).

For consistency, I've changed "writeable" to "writable" in all test cases, except for 1 test which specifically aims to check that that "legacy" spelling is accepted.

oxc/crates/oxc_linter/src/config/globals.rs

Lines 161 to 168 in 00c5614

	fn test_deserialize_legacy_spelling() {
	let globals = globals!({
	"foo": "readable",
	"bar": "writeable",
	});
	assert!(globals.is_enabled("foo"));
	assert!(globals.is_enabled("bar"));
	}

[overlookmotel]

• perf(linter/plugins): remove code for renaming global values #16610
• refactor(linter): rename GlobalValue::Writeable to Writable #16609 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #16609 will not alter performance

_{Comparing 12-08-refactor_linter_rename_globalvalue_writeable_to_writable_ (00c5614) with main (767db50)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on main (198e6e2) during the generation of this report, so 767db50 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR corrects the spelling of the GlobalValue enum variant from Writeable to Writable, aligning with ESLint's canonical spelling. The change ensures that globals are serialized with the correct spelling ("writable" instead of "writeable"), while maintaining full backward compatibility by continuing to accept "writeable" as input through the TryFrom<&str> implementation.

Key Changes

• Renamed GlobalValue::Writeable to GlobalValue::Writable in the Rust enum
• Updated serialization to use "writable" as the canonical form
• Maintained backward compatibility by accepting both "writable" and "writeable" in deserialization

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_linter/src/config/globals.rs	Renamed enum variant from Writeable to Writable, updated as_str() method, and updated From<bool> implementation while preserving backward compatibility in TryFrom<&str>
crates/oxc_linter/src/config/config_store.rs	Updated test cases to use "writable" instead of "writeable" in JSON test data
apps/oxlint/fixtures/overrides_env_globals/.oxlintrc.json	Updated fixture configuration file to use canonical "writable" spelling
npm/oxlint/configuration_schema.json	Updated schema enum to list "writable" instead of "writeable" as the canonical value
crates/oxc_linter/src/snapshots/schema_json.snap	Updated snapshot to reflect schema changes
editors/vscode/tests/test-helpers.ts	Updated TypeScript type definition to use "writable" instead of "writeable"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camc314]

Merge activity

• Dec 8, 3:19 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 8, 3:19 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 8, 3:26 PM UTC: Merged by the Graphite merge queue.