added test-id to button element - related to pr2496 #2534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jivey
requested changes
Jul 14, 2025
| <Styled.CloseIconButton onClick={this.props.onClose}> | ||
| <Styled.CloseIconButton | ||
| onClick={this.props.onClose} | ||
| data-testid='close-search-noresults' |
There was a problem hiding this comment.
@jivey I think they are indented, it's just how it is shown here in github, no?
There was a problem hiding this comment.
I mean indented 2 more spaces so visually it's easy to tell where the tag properties are - here's an example:
There was a problem hiding this comment.
ok. on it. missed that...
|
All tests passed. Those 2 playwright tests are known and waiting for updates and deploy of rex |
jivey
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #2496
added test-id as per discussion with @Dantemss
https://openstax.atlassian.net/browse/CORE-988