-
Notifications
You must be signed in to change notification settings - Fork 2
selector change in highlight test #2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not good to use these auto-generated classes from styled-components, as they can change anytime for whatever reason. Try to see if there are any other classes around the element that you can use, like a class on the parent. If not, maybe we can add one.
@Dantemss There is no good class to select as they are all styled_... Could you add a class or id for this X button? |
@Dantemss this is the element |
I mean... you can add the class :) search for CloseIconWrapper and add a data-testid or className (there's an example elsewhere in Rex that already has a data-testid, make sure you found the one that goes to the search results sidebar). Or try something like |
https://openstax.atlassian.net/browse/CORE-988
Tiny one line change - had to replace a selector for a page object
Note. The one highlight test will fail until the new behaviour is fixed.