Skip to content

selector change in highlight test #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

selector change in highlight test #2496

wants to merge 2 commits into from

Conversation

omehes
Copy link
Contributor

@omehes omehes commented Jul 9, 2025

https://openstax.atlassian.net/browse/CORE-988
Tiny one line change - had to replace a selector for a page object

Note. The one highlight test will fail until the new behaviour is fixed.

@omehes omehes requested a review from a team as a code owner July 9, 2025 16:31
@omehes omehes requested a review from Dantemss July 9, 2025 16:31
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 9, 2025 16:31 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:16 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:19 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:20 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:21 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:21 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:23 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:25 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:26 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:32 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:34 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:54 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 10, 2025 20:54 Inactive
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not good to use these auto-generated classes from styled-components, as they can change anytime for whatever reason. Try to see if there are any other classes around the element that you can use, like a class on the parent. If not, maybe we can add one.

@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 22:26 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 22:27 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 22:28 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 23:08 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 23:09 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 23:09 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 23:10 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 23:10 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 11, 2025 23:11 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-selerror-u5maxppip06w7 July 12, 2025 02:52 Inactive
@omehes
Copy link
Contributor Author

omehes commented Jul 14, 2025

@Dantemss There is no good class to select as they are all styled_... Could you add a class or id for this X button?

@omehes
Copy link
Contributor Author

omehes commented Jul 14, 2025

@Dantemss this is the element
Image 7-14-25 at 9 12 AM

@Dantemss
Copy link
Member

I mean... you can add the class :) search for CloseIconWrapper and add a data-testid or className (there's an example elsewhere in Rex that already has a data-testid, make sure you found the one that goes to the search results sidebar).

Or try something like div[data-testid="search-results-sidebar"] button, if the button will accept the click as well (and if it's the only button in the search results sidebar).

@omehes
Copy link
Contributor Author

omehes commented Jul 14, 2025

@Dantemss here is the pr with the updated selector which is related to #2534, where I added test id to the element in question (as per our discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants