Skip to content

Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods [4.1]#23584

Merged
openshift-merge-robot merged 1 commit into
openshift:release-4.1from
sjenning:pick-80491-4.1
Aug 25, 2019
Merged

Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods [4.1]#23584
openshift-merge-robot merged 1 commit into
openshift:release-4.1from
sjenning:pick-80491-4.1

Conversation

@sjenning

@sjenning sjenning commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

@openshift-ci-robot

Copy link
Copy Markdown

@sjenning: This pull request references an invalid Bugzilla bug:

  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2019
@sjenning sjenning changed the title Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods [4.1] Aug 9, 2019
@sjenning

Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot

Copy link
Copy Markdown

@sjenning: This pull request references a valid Bugzilla bug. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 15, 2019
@sjenning

Copy link
Copy Markdown
Contributor Author

/retest

@eparis

eparis commented Aug 24, 2019

Copy link
Copy Markdown
Member

This PR requires review/lgtm/approval from the engineering team

@derekwaynecarr

derekwaynecarr commented Aug 24, 2019 via email

Copy link
Copy Markdown
Member

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2019
@openshift-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [derekwaynecarr,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 24, 2019
@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fc00028 into openshift:release-4.1 Aug 25, 2019
@openshift-ci-robot

Copy link
Copy Markdown

@sjenning: All pull requests linked via external trackers have merged. Bugzilla bug 1739603 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1739603: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods [4.1]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants