Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods

[sjenning]

kubernetes/kubernetes#80491

Proactive pick for upstream fix.

Some fuzz around kubernetes/kubernetes@ca6003b#diff-9fe046de3c6aaa377bb7fa24a34509c9 but otherwise it applies cleanly.

Extra +/-1 line changed is goimports adding v1 alias
https://github.com/openshift/origin/pull/23576/files#diff-5cdd56e52dd392c4f849386f73dc723aR23

@derekwaynecarr @mrunalp

[mrunalp]

/lgtm

[mfojtik]

/retest

[mfojtik]

Need a BZ reference after feature freeze :-)

/hold

[sjenning]

I'm fine leaving it until 4.3 unless @derekwaynecarr wants to push it in for 4.2

[derekwaynecarr]

This should go all the way back to 4.1.

[openshift-ci-robot]

@sjenning: An error was encountered updating the bug to the POST state on the Bugzilla server at https://bugzilla.redhat.com for bug 1739601:

response code 502 not 200
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sjenning]

/bugzilla refresh

[openshift-ci-robot]

@sjenning: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sjenning]

/hold cancel

[derekwaynecarr]

/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, mrunalp, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [derekwaynecarr,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@sjenning: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

Details

In response to this:

Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.