Skip to content

networking overview #95770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

networking overview #95770

merged 1 commit into from
Jul 16, 2025

Conversation

JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Jul 8, 2025

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/OSDOCS-15186

Link to docs preview:
https://95770--ocpdocs-pr.netlify.app/

QE review:

  • QE has approved this change.

Additional information:
This PR reorganizes the Networking book into 10 separate books with sub-directories.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2025
@stevsmit
Copy link
Member

stevsmit commented Jul 8, 2025

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 8, 2025

🤖 Wed Jul 16 18:31:39 - Prow CI generated the docs preview:
https://95770--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2025
@JoeAldinger JoeAldinger force-pushed the OSDOCS-15188 branch 5 times, most recently from e62fd11 to 89dfe87 Compare July 9, 2025 16:47
@@ -24,7 +24,7 @@ When using the {product-title} (ROSA) command-line interface (CLI), `rosa`, to c
+
[NOTE]
====
When creating a {hcp-title} cluster, the default machine Classless Inter-Domain Routing (CIDR) is `10.0.0.0/16`. If this does not correspond to the CIDR range for your VPC subnets, add `--machine-cidr <address_block>` to the following commands. To learn more about the default CIDR ranges for {product-title}, see xref:../networking/cidr-range-definitions.adoc#cidr-range-definitions[CIDR range definitions].
When creating a {hcp-title} cluster, the default machine Classless Inter-Domain Routing (CIDR) is `10.0.0.0/16`. If this does not correspond to the CIDR range for your VPC subnets, add `--machine-cidr <address_block>` to the following commands. To learn more about the default CIDR ranges for {product-title}, see xref:../networking/networking_overview/cidr-range-definitions.adoc#cidr-range-definitions[CIDR range definitions].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies.

@JoeAldinger JoeAldinger force-pushed the OSDOCS-15188 branch 3 times, most recently from 48ffcc0 to 838210a Compare July 9, 2025 18:17
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2025
@JoeAldinger JoeAldinger force-pushed the OSDOCS-15188 branch 12 times, most recently from 091e6a9 to 6a8fe9c Compare July 14, 2025 14:28
@JoeAldinger JoeAldinger force-pushed the OSDOCS-15188 branch 5 times, most recently from e8ffdb2 to b91a588 Compare July 16, 2025 13:37
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.20 labels Jul 16, 2025
@stevsmit stevsmit added this to the Continuous Release milestone Jul 16, 2025
Ingress and load balancing

Advanced networking

configuring network settings
Copy link

openshift-ci bot commented Jul 16, 2025

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit
Copy link
Member

Let's goooooooooooooo

@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 16, 2025
@stevsmit
Copy link
Member

We've compiled a list of things that could be fixed in the future. Nothing damning here; all of the xrefs work and the git diff looks good. Merging.

@stevsmit stevsmit merged commit c641ded into openshift:main Jul 16, 2025
2 checks passed
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.20

@openshift-cherrypick-robot

@stevsmit: #95770 failed to apply on top of branch "enterprise-4.20":

Applying: networking overview
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	_topic_maps/_topic_map_osd.yml
M	_topic_maps/_topic_map_rosa.yml
M	installing/installing_aws/ipi/installing-aws-network-customizations.adoc
M	networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
M	networking/metallb/metallb-troubleshoot-support.adoc
M	networking/networking_operators/metallb-operator/about-metallb.adoc
M	welcome/learn_more_about_openshift.adoc
Falling back to patching base and 3-way merge...
Auto-merging welcome/learn_more_about_openshift.adoc
Auto-merging networking/networking_operators/metallb-operator/about-metallb.adoc
Auto-merging networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/routes/snippets
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/metallb/snippets
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/metallb/modules
Auto-merging networking/ingress_load_balancing/metallb/metallb-troubleshoot-support.adoc
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/metallb/images
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/configuring_ingress_cluster_traffic/snippets
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/_attributes
CONFLICT (content): Merge conflict in networking/configuring_network_settings/modules
CONFLICT (content): Merge conflict in networking/configuring_network_settings/images
CONFLICT (content): Merge conflict in networking/configuring_network_settings/_attributes
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/snippets
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/modules
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/images
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/_attributes
CONFLICT (content): Merge conflict in networking/advanced_networking/modules
CONFLICT (content): Merge conflict in networking/advanced_networking/images
CONFLICT (content): Merge conflict in networking/advanced_networking/_attributes
Auto-merging installing/installing_aws/ipi/installing-aws-network-customizations.adoc
Auto-merging _topic_maps/_topic_map_rosa.yml
Auto-merging _topic_maps/_topic_map_osd.yml
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 networking overview

In response to this:

/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.19

@openshift-cherrypick-robot

@stevsmit: #95770 failed to apply on top of branch "enterprise-4.19":

Applying: networking overview
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	_topic_maps/_topic_map_osd.yml
M	_topic_maps/_topic_map_rosa.yml
M	installing/installing_aws/ipi/installing-aws-network-customizations.adoc
M	networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
M	networking/metallb/metallb-troubleshoot-support.adoc
M	networking/networking_operators/metallb-operator/about-metallb.adoc
M	welcome/learn_more_about_openshift.adoc
Falling back to patching base and 3-way merge...
Auto-merging welcome/learn_more_about_openshift.adoc
Auto-merging networking/networking_operators/metallb-operator/about-metallb.adoc
Auto-merging networking/k8s_nmstate/k8s-nmstate-updating-node-network-config.adoc
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/routes/snippets
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/metallb/snippets
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/metallb/modules
Auto-merging networking/ingress_load_balancing/metallb/metallb-troubleshoot-support.adoc
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/metallb/images
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/configuring_ingress_cluster_traffic/snippets
CONFLICT (content): Merge conflict in networking/ingress_load_balancing/_attributes
CONFLICT (content): Merge conflict in networking/configuring_network_settings/modules
CONFLICT (content): Merge conflict in networking/configuring_network_settings/images
CONFLICT (content): Merge conflict in networking/configuring_network_settings/_attributes
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/snippets
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/modules
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/images
CONFLICT (content): Merge conflict in networking/advanced_networking/ptp/_attributes
CONFLICT (content): Merge conflict in networking/advanced_networking/modules
CONFLICT (content): Merge conflict in networking/advanced_networking/images
CONFLICT (content): Merge conflict in networking/advanced_networking/_attributes
Auto-merging installing/installing_aws/ipi/installing-aws-network-customizations.adoc
Auto-merging _topic_maps/_topic_map_rosa.yml
Auto-merging _topic_maps/_topic_map_osd.yml
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 networking overview

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants