Skip to content

Conversation

@sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Nov 2, 2021

Signed-off-by: Sruti Parthiban [email protected]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#68

Describe the solution you are proposing
Add DCO checks and fix failing IT.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #78 (ac47d88) into main (184caae) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #78      +/-   ##
============================================
- Coverage     72.11%   71.95%   -0.16%     
+ Complexity      356      354       -2     
============================================
  Files            44       44              
  Lines          2510     2510              
  Branches        160      160              
============================================
- Hits           1810     1806       -4     
- Misses          595      597       +2     
- Partials        105      107       +2     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 53.57% <0.00%> (-7.15%) ⬇️
...nalyzer/collectors/ThreadPoolMetricsCollector.java 90.66% <0.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184caae...ac47d88. Read the comment docs.

@sruti1312 sruti1312 requested a review from kjoseph07 November 2, 2021 21:09
@sruti1312 sruti1312 merged commit 94958cf into main Nov 2, 2021
@sruti1312 sruti1312 deleted the feature/add-dco branch November 2, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants