Skip to content

Commit a79a451

Browse files
committed
Add DCO workflow and fix failing IT
Signed-off-by: Sruti Parthiban <[email protected]>
1 parent 184caae commit a79a451

File tree

2 files changed

+26
-8
lines changed

2 files changed

+26
-8
lines changed

.github/workflows/dco.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
name: Developer Certificate of Origin Check
2+
3+
on: [pull_request]
4+
5+
jobs:
6+
check:
7+
runs-on: ubuntu-latest
8+
9+
steps:
10+
- name: Get PR Commits
11+
id: 'get-pr-commits'
12+
uses: tim-actions/[email protected]
13+
with:
14+
token: ${{ secrets.GITHUB_TOKEN }}
15+
- name: DCO Check
16+
uses: tim-actions/[email protected]
17+
with:
18+
commits: ${{ steps.get-pr-commits.outputs.commits }}

src/test/java/org/opensearch/performanceanalyzer/ConfigOverridesIT.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,16 @@ public class ConfigOverridesIT extends PerformanceAnalyzerIntegTestBase {
5858

5959
@Test
6060
public void testSimpleOverride() throws Exception {
61-
testSimpleOverride(CONFIG_OVERRIDES_ENDPOINT);
61+
testSimpleOverride(RestConfig.PA_BASE_URI, CONFIG_OVERRIDES_ENDPOINT);
6262
}
6363

6464
@Test
6565
public void testLegacySimpleOverride() throws Exception {
66-
testSimpleOverride(LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
66+
testSimpleOverride(RestConfig.LEGACY_PA_BASE_URI, LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
6767
}
6868

69-
public void testSimpleOverride(String configOverridesEndpoint) throws Exception {
70-
ensurePaAndRcaEnabled(configOverridesEndpoint);
69+
public void testSimpleOverride(String paBaseUri, String configOverridesEndpoint) throws Exception {
70+
ensurePaAndRcaEnabled(paBaseUri);
7171
final ConfigOverrides overrides =
7272
getOverrides(
7373
Arrays.asList(HOT_SHARD_RCA, HOT_NODE_CLUSTER_RCA),
@@ -106,16 +106,16 @@ public void testSimpleOverride(String configOverridesEndpoint) throws Exception
106106

107107
@Test
108108
public void testCompositeOverrides() throws Exception {
109-
testCompositeOverrides(CONFIG_OVERRIDES_ENDPOINT);
109+
testCompositeOverrides(RestConfig.PA_BASE_URI, CONFIG_OVERRIDES_ENDPOINT);
110110
}
111111

112112
@Test
113113
public void testLegacyCompositeOverrides() throws Exception {
114-
testCompositeOverrides(LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
114+
testCompositeOverrides(RestConfig.LEGACY_PA_BASE_URI, LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
115115
}
116116

117-
public void testCompositeOverrides(String configOverridesEndpoint) throws Exception {
118-
ensurePaAndRcaEnabled(configOverridesEndpoint);
117+
public void testCompositeOverrides(String paBaseUri, String configOverridesEndpoint) throws Exception {
118+
ensurePaAndRcaEnabled(paBaseUri);
119119

120120
final ConfigOverrides initialOverrides =
121121
getOverrides(

0 commit comments

Comments
 (0)