-
Notifications
You must be signed in to change notification settings - Fork 1
688 ftp update #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
688 ftp update #214
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
23e1401
add search select field for FTP configs
christophkohl1 d4bb35e
refactoring
christophkohl1 10e6495
changes
christophkohl1 b9fc70b
display logic
christophkohl1 2b9d1bb
Merge branch 'develop' into 688-ftp-update
christophkohl1 a3d1d8b
added path concatenation logic
christophkohl1 428037f
add test ftp connection functionality
christophkohl1 a4c1586
Merge branch 'develop' into 688-ftp-update
christophkohl1 b2492eb
icon
christophkohl1 21fbc0d
remove identifier ns field from provider search
christophkohl1 7ab8db7
texts
christophkohl1 53a8c80
Merge branch 'develop' into 688-ftp-update
christophkohl1 c11686f
textsrefactor
christophkohl1 203de36
Merge branch 'develop' into 688-ftp-update
christophkohl1 8e03fb5
Merge branch 'develop' into 688-ftp-update
christophkohl1 c677b38
external source import - allow only wekb as import source
christophkohl1 4d86c59
refactoring
christophkohl1 0a3487a
refactor ftpUrl fieldname, add validation to reject ftp urls occasion…
christophkohl1 e47e508
add validation error messages
christophkohl1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When HTTP is selected,
ftpUrlandwebEndpointare not cleared, and an existingurlcan be invisibly present for FTP sources. May not be that problematic right now, but it might cause issues in future.When HTTP is selected, URLs starting with
ftpshould no longer be valid forurl. Needs adjustment to backend validation.