Conversation
# Conflicts: # src/shared/components/complex/gokb-source-field/gokb-source-field.vue
hornmo
reviewed
Feb 6, 2026
| } | ||
| }, | ||
| "transferMethod": { | ||
| "label": "Transfer Methode", |
| <v-row> | ||
| <v-col cols="3"> | ||
| <gokb-state-field | ||
| v-model="item.transferMethod" |
Collaborator
There was a problem hiding this comment.
When HTTP is selected, ftpUrl and webEndpoint are not cleared, and an existing url can be invisibly present for FTP sources. May not be that problematic right now, but it might cause issues in future.
When HTTP is selected, URLs starting with ftp should no longer be valid for url. Needs adjustment to backend validation.
| this.isFTPTransfer = true | ||
| } | ||
|
|
||
| this.$watch(vm => [vm.item.ftpUrl, vm.item.transferMethod, vm.item.webEndpoint], |
Collaborator
There was a problem hiding this comment.
Why here and not in watch()?
| <v-col cols="3"> | ||
| <gokb-webendpoint-field | ||
| v-model="item.webEndpoint" | ||
| filterByProtocol="FTP" |
Collaborator
There was a problem hiding this comment.
Camel case only inside of the component properties, here it should be filter-by-protocol
hornmo
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.