Skip to content

Conversation

@superlopuh
Copy link
Contributor

No description provided.

@superlopuh superlopuh marked this pull request as draft October 2, 2025 09:35
@superlopuh superlopuh requested a review from zero9178 October 6, 2025 18:57
@superlopuh superlopuh self-assigned this Oct 6, 2025
@superlopuh superlopuh changed the title fix typo fix CI Oct 6, 2025
@zero9178
Copy link
Member

zero9178 commented Oct 9, 2025

I am not very familiar with uv, but is the venv you are creating any different than the venv that the cmake script already tries to create? And is it using the right python interpreter?

Does uv also potentially install xdsl-opt somewhere else?

find_program(XDSL_OPT_PATH xdsl-opt

The logic here currently only looks for xdsl-opt, optionally within bin directories, within the parent path of the directory containing the interpreter. If theyre installed elsewhere by uv itd be a convenient heuristic to add these paths to the PATHS argument.
Worst case you can also set -DXDSL_OPT_PATH=... on the cmake command line when configuring

@superlopuh
Copy link
Contributor Author

OK latest changes work, this is what I did:

uv pip install -r requirements.txt --exclude-newer 2024-09-01
uv pip freeze > requirements_frozen.txt
# manually edit the xdsl install path

@superlopuh superlopuh marked this pull request as ready for review October 9, 2025 17:55
@superlopuh superlopuh merged commit 30120ba into main Oct 9, 2025
1 check passed
@superlopuh superlopuh deleted the sasha/fix-ci branch October 9, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants