Skip to content

Commit 0c43c0b

Browse files
authored
[build] Disable use of logf128 to fix build failures (#138)
This PR: - Disables the use (and auto-detection during build configuration) of the natural logarithm on FP128 that caused a build failure within IREE's bundled LLVM (this is related to this [fix](llvm/llvm-project#100296)). ### Description IREE ships with a bundled LLVM within its `third_party` subdirectory to allow code generation of various targets (e.g., RISC-V via the LLVM-CPU backend). This bundled LLVM has limited configurability (mostly hardcoded via [`iree_llvm.cmake`](https://github.com/iree-org/iree/blob/456d80c51930ccc03ce0488e98238e5e0a14b403/build_tools/cmake/iree_llvm.cmake#L17)), hence we rely on `cmake` to propagate this compile definition from the top-level directory when building Quidditch's `codegen` sub-project. This behaviour was first exhibited when the host compiler was updated (on a local build host) to version 19.1.7.
1 parent 6424dd0 commit 0c43c0b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ ExternalProject_Add(codegen
4949
CMAKE_ARGS
5050
-DIREE_ENABLE_LLD=ON
5151
-DQUIDDITCH_TOOLCHAIN_ROOT=${QUIDDITCH_TOOLCHAIN_ROOT}
52+
-DHAS_LOGF128=0 # resolves bundled LLVM compilation failures related to https://github.com/llvm/llvm-project/issues/100296
5253
${host_cmake_args}
5354
SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}/codegen
5455
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/codegen

0 commit comments

Comments
 (0)