fix: change value type of Baggage to StringValue#2729
fix: change value type of Baggage to StringValue#2729cijothomas merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
=======================================
- Coverage 79.4% 79.4% -0.1%
=======================================
Files 123 123
Lines 22737 22748 +11
=======================================
+ Hits 18060 18063 +3
- Misses 4677 4685 +8 ☔ View full report in Codecov by Sentry. |
|
@gruebel Thanks for addressing this! I agree it is not possible to do this without breaking, so let's do it. I also think we should make sure we can review Baggage entirely and finish up all breaking changes (if any) before next release, and mark Baggage also as RC status, preventing further breaking changes to it. |
|
Oh nice, didn't see that PR. I can wait till his changes are merged and then rebase my afterwards or vice versa. |
cijothomas
left a comment
There was a problem hiding this comment.
LGTM.
Its breaking change, but necessary cost to take to get to stable.
Merged this one first as this is affecting public API and want to get Baggage towards stable/rc by next release. Apologies for the delay - I was focused on Logs/Metrics and only now had bandwidth to look at Baggage! |
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
Fixes #2716
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes