perf: Baggage insert & BaggageExt::with_baggage & updated constants to latest standard#2284
Merged
cijothomas merged 2 commits intoopen-telemetry:mainfrom Mar 2, 2025
Merged
Conversation
9c71657 to
66cd5f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 123 123
Lines 22748 22736 -12
=====================================
- Hits 18063 18058 -5
+ Misses 4685 4678 -7 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Nov 7, 2024
a20d014 to
8438828
Compare
cijothomas
reviewed
Feb 26, 2025
cijothomas
approved these changes
Feb 26, 2025
Member
cijothomas
left a comment
There was a problem hiding this comment.
LGTM.
Would be good to add a changelog entry for the fixes in size/length validations fixes.
Will open separate issue to make Baggage spec compliant.
This was referenced Feb 26, 2025
91eef2f to
5efb903
Compare
…& updated constants to the latest standard
5efb903 to
cc7cd67
Compare
cijothomas
approved these changes
Mar 2, 2025
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Improve few things:
BaggageExt::with_baggagenow "clone" baggage, instead of iterate+collect.Baggage::insert_with_metadata(used everywhere) should be a bit faster, as it had redundant calculations:Baggage::iterMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes