Skip to content

Conversation

@yumosx
Copy link
Member

@yumosx yumosx commented Oct 23, 2025

goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/sdk/log/internal/observ
cpu: Apple M3
                            │ bench_res.txt │
                            │    sec/op     │
SLP/LogProcessed-8             0.8900n ± 2%
SLP/LogProcessedWithError-8     119.2n ± 5%
geomean                         10.30n

                            │ bench_res.txt │
                            │     B/op      │
SLP/LogProcessed-8             0.000 ± 0%
SLP/LogProcessedWithError-8    232.0 ± 0%
geomean                                   ¹
¹ summaries must be >0 to compute geomean

                            │ bench_res.txt │
                            │   allocs/op   │
SLP/LogProcessed-8             0.000 ± 0%
SLP/LogProcessedWithError-8    3.000 ± 0%
geomean                                   ¹
¹ summaries must be >0 to compute geomean

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.1%. Comparing base (f1ba319) to head (45d801a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7532   +/-   ##
=====================================
  Coverage   86.1%   86.1%           
=====================================
  Files        295     296    +1     
  Lines      21550   21594   +44     
=====================================
+ Hits       18557   18599   +42     
- Misses      2620    2622    +2     
  Partials     373     373           
Files with missing lines Coverage Δ
sdk/log/internal/observ/simple_log_processor.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yumosx yumosx marked this pull request as draft October 23, 2025 13:38
@yumosx yumosx marked this pull request as ready for review October 23, 2025 13:56
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 23, 2025
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. One minor documentation change needed.

@dmathieu dmathieu merged commit b15942f into open-telemetry:main Oct 24, 2025
30 checks passed
@MrAlias MrAlias added this to the v1.39.0 milestone Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants