Instrument manual reader from sdk/metric #7524

tongoss · 2025-10-21T00:32:13Z

Resolve: #7009

Benchmarks

➜ benchstat /tmp/manual_bench_disabled.txt /tmp/manual_bench_enabled.txt
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/sdk/metric
cpu: Apple M1 Max
                                               │ /tmp/manual_bench_disabled.txt │    /tmp/manual_bench_enabled.txt    │
                                               │             sec/op             │    sec/op     vs base               │
ManualReaderInstrumentation/NoObservability-10                     35.98µ ± 14%   36.29µ ± 11%       ~ (p=0.665 n=40)
ManualReaderInstrumentation/Observability-10                       26.98µ ±  9%   28.23µ ±  3%       ~ (p=0.207 n=40)
geomean                                                            31.16µ         32.01µ        +2.73%

                                               │ /tmp/manual_bench_disabled.txt │    /tmp/manual_bench_enabled.txt    │
                                               │              B/op              │     B/op      vs base               │
ManualReaderInstrumentation/NoObservability-10                     49.24Ki ± 1%   49.24Ki ± 1%       ~ (p=1.000 n=40)
ManualReaderInstrumentation/Observability-10                       51.78Ki ± 0%   51.78Ki ± 0%       ~ (p=0.485 n=40)
geomean                                                            50.50Ki        50.50Ki       +0.00%

                                               │ /tmp/manual_bench_disabled.txt │   /tmp/manual_bench_enabled.txt   │
                                               │           allocs/op            │ allocs/op   vs base               │
ManualReaderInstrumentation/NoObservability-10                       381.0 ± 1%   381.0 ± 1%       ~ (p=1.000 n=40)
ManualReaderInstrumentation/Observability-10                         387.0 ± 0%   387.0 ± 1%       ~ (p=0.485 n=40)
geomean                                                              384.0        384.0       +0.00%

codecov · 2025-10-21T00:34:12Z

Codecov Report

❌ Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.1%. Comparing base (4438ec3) to head (23025b3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sdk/metric/manual_reader.go	93.7%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #7524   +/-   ##
=====================================
  Coverage   86.1%   86.1%           
=====================================
  Files        296     297    +1     
  Lines      21594   21664   +70     
=====================================
+ Hits       18598   18672   +74     
+ Misses      2623    2620    -3     
+ Partials     373     372    -1

Files with missing lines	Coverage Δ
sdk/metric/internal/observ/instrumentation.go	`100.0% <100.0%> (ø)`
sdk/metric/manual_reader.go	`83.1% <93.7%> (+2.6%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dmathieu · 2025-10-30T08:54:32Z

The runtime error seems to be linked to #7532

tongoss · 2025-10-30T12:29:58Z

The runtime error seems to be linked to #7532

@dmathieu , agreed. Thanks for fix.

Calling other metrics from this meter provider should be a noop, not a panic. This fixes the test suite in #7524

MrAlias

Overall looks good 👍

sdk/metric/internal/observ/instrumentation_test.go

Co-authored-by: Tyler Yahn <[email protected]>

tongoss · 2025-11-03T22:27:09Z

Overall looks good 👍

Thanks very much, @MrAlias . I have applied the suggested changes and updated the branch accordingly.

## Overview ### Added - Greatly reduce the cost of recording metrics in `go.opentelemetry.io/otel/sdk/metric` using hashing for map keys. (#7175) - Add `WithInstrumentationAttributeSet` option to `go.opentelemetry.io/otel/log`, `go.opentelemetry.io/otel/metric`, and `go.opentelemetry.io/otel/trace` packages. This provides a concurrent-safe and performant alternative to `WithInstrumentationAttributes` by accepting a pre-constructed `attribute.Set`. (#7287) - Add experimental observability for the Prometheus exporter in `go.opentelemetry.io/otel/exporters/prometheus`. Check the `go.opentelemetry.io/otel/exporters/prometheus/internal/x` package documentation for more information. (#7345) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#7353) - Add temporality selector functions `DeltaTemporalitySelector`, `CumulativeTemporalitySelector`, `LowMemoryTemporalitySelector` to `go.opentelemetry.io/otel/sdk/metric`. (#7434) - Add experimental observability metrics for simple log processor in `go.opentelemetry.io/otel/sdk/log`. (#7548) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#7459) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#7486) - Add experimental observability metrics for simple span processor in `go.opentelemetry.io/otel/sdk/trace`. (#7374) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#7512) - Add experimental observability metrics for manual reader in `go.opentelemetry.io/otel/sdk/metric`. (#7524) - Add experimental observability metrics for periodic reader in `go.opentelemetry.io/otel/sdk/metric`. (#7571) - Support `OTEL_EXPORTER_OTLP_LOGS_INSECURE` and `OTEL_EXPORTER_OTLP_INSECURE` environmental variables in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#7608) - Add `Enabled` method to the `Processor` interface in `go.opentelemetry.io/otel/sdk/log`. All `Processor` implementations now include an `Enabled` method. (#7639) - The `go.opentelemetry.io/otel/semconv/v1.38.0` package. The package contains semantic conventions from the `v1.38.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.38.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.37.0.`(#7648) ### Changed - `Distinct` in `go.opentelemetry.io/otel/attribute` is no longer guaranteed to uniquely identify an attribute set. Collisions between `Distinct` values for different Sets are possible with extremely high cardinality (billions of series per instrument), but are highly unlikely. (#7175) - `WithInstrumentationAttributes` in `go.opentelemetry.io/otel/trace` synchronously de-duplicates the passed attributes instead of delegating it to the returned `TracerOption`. (#7266) - `WithInstrumentationAttributes` in `go.opentelemetry.io/otel/meter` synchronously de-duplicates the passed attributes instead of delegating it to the returned `MeterOption`. (#7266) - `WithInstrumentationAttributes` in `go.opentelemetry.io/otel/log` synchronously de-duplicates the passed attributes instead of delegating it to the returned `LoggerOption`. (#7266) - Rename the `OTEL_GO_X_SELF_OBSERVABILITY` environment variable to `OTEL_GO_X_OBSERVABILITY` in `go.opentelemetry.io/otel/sdk/trace`, `go.opentelemetry.io/otel/sdk/log`, and `go.opentelemetry.io/otel/exporters/stdout/stdouttrace`. (#7302) - Improve performance of histogram `Record` in `go.opentelemetry.io/otel/sdk/metric` when min and max are disabled using `NoMinMax`. (#7306) - Improve error handling for dropped data during translation by using `prometheus.NewInvalidMetric` in `go.opentelemetry.io/otel/exporters/prometheus`. ⚠️ **Breaking Change:** Previously, these cases were only logged and scrapes succeeded. Now, when translation would drop data (e.g., invalid label/value), the exporter emits a `NewInvalidMetric`, and Prometheus scrapes **fail with HTTP 500** by default. To preserve the prior behavior (scrapes succeed while errors are logged), configure your Prometheus HTTP handler with: `promhttp.HandlerOpts{ ErrorHandling: promhttp.ContinueOnError }`. (#7363) - Replace fnv hash with xxhash in `go.opentelemetry.io/otel/attribute` for better performance. (#7371) - The default `TranslationStrategy` in `go.opentelemetry.io/exporters/prometheus` is changed from `otlptranslator.NoUTF8EscapingWithSuffixes` to `otlptranslator.UnderscoreEscapingWithSuffixes`. (#7421) - Improve performance of concurrent measurements in `go.opentelemetry.io/otel/sdk/metric`. (#7427) - Include W3C TraceFlags (bits 0–7) in the OTLP `Span.Flags` field in `go.opentelemetry.io/exporters/otlp/otlptrace/otlptracehttp` and `go.opentelemetry.io/exporters/otlp/otlptrace/otlptracegrpc`. (#7438) - The `ErrorType` function in `go.opentelemetry.io/otel/semconv/v1.37.0` now handles custom error types. If an error implements an `ErrorType() string` method, the return value of that method will be used as the error type. (#7442) ### Fixed - Fix `WithInstrumentationAttributes` options in `go.opentelemetry.io/otel/trace`, `go.opentelemetry.io/otel/metric`, and `go.opentelemetry.io/otel/log` to properly merge attributes when passed multiple times instead of replacing them. Attributes with duplicate keys will use the last value passed. (#7300) - The equality of `attribute.Set` when using the `Equal` method is not affected by the user overriding the empty set pointed to by `attribute.EmptySet` in `go.opentelemetry.io/otel/attribute`. (#7357) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#7372) - Fix `AddAttributes`, `SetAttributes`, `SetBody` on `Record` in `go.opentelemetry.io/otel/sdk/log` to not mutate input. (#7403) - Do not double record measurements of `RecordSet` methods in `go.opentelemetry.io/otel/semconv/v1.37.0`. (#7655) - Do not double record measurements of `RecordSet` methods in `go.opentelemetry.io/otel/semconv/v1.36.0`. (#7656) ### Removed - Drop support for [Go 1.23]. (#7274) - Remove the `FilterProcessor` interface in `go.opentelemetry.io/otel/sdk/log`. The `Enabled` method has been added to the `Processor` interface instead. All `Processor` implementations must now implement the `Enabled` method. Custom processors that do not filter records can implement `Enabled` to return `true`. (#7639)

tongoss added 2 commits October 20, 2025 20:37

inst manual reader from sdk/metric

f3edd0d

update CHANGELOG.md

e1fa8d2

tongoss force-pushed the feature/inst-manual-reader-v2 branch from c0c715e to e1fa8d2 Compare October 21, 2025 00:37

tongoss marked this pull request as ready for review October 21, 2025 00:43

tongoss requested review from MrAlias, XSAM, dashpole, dmathieu, flc1125 and pellared as code owners October 21, 2025 00:43

dashpole approved these changes Oct 28, 2025

View reviewed changes

flc1125 approved these changes Oct 29, 2025

View reviewed changes

Merge branch 'main' into feature/inst-manual-reader-v2

b6d6ecd

dmathieu approved these changes Oct 30, 2025

View reviewed changes

dmathieu mentioned this pull request Oct 30, 2025

chore: handle Float64Histogram in log/observe errMeter #7555

Merged

MrAlias pushed a commit that referenced this pull request Oct 31, 2025

chore: handle Float64Histogram in log/observe errMeter (#7555)

e308db8

Calling other metrics from this meter provider should be a noop, not a panic. This fixes the test suite in #7524

MrAlias approved these changes Nov 3, 2025

View reviewed changes

sdk/metric/internal/observ/instrumentation_test.go Outdated Show resolved Hide resolved

tongoss and others added 2 commits November 3, 2025 17:10

Apply suggestion from @MrAlias

e5e33b9

Co-authored-by: Tyler Yahn <[email protected]>

Merge branch 'main' into feature/inst-manual-reader-v2

23025b3

MrAlias merged commit 68190cc into open-telemetry:main Nov 3, 2025
33 checks passed

MrAlias added this to the v1.39.0 milestone Dec 4, 2025

MrAlias mentioned this pull request Dec 5, 2025

Release v1.39.0 #7676

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Instrument manual reader from sdk/metric #7524

Instrument manual reader from sdk/metric #7524

Uh oh!

tongoss commented Oct 21, 2025

Uh oh!

codecov bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

dmathieu commented Oct 30, 2025

Uh oh!

tongoss commented Oct 30, 2025 •

edited

Loading

Uh oh!

MrAlias left a comment

Uh oh!

Uh oh!

tongoss commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Instrument manual reader from sdk/metric #7524

Instrument manual reader from sdk/metric #7524

Uh oh!

Conversation

tongoss commented Oct 21, 2025

Benchmarks

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dmathieu commented Oct 30, 2025

Uh oh!

tongoss commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrAlias left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tongoss commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Oct 21, 2025 •

edited

Loading

tongoss commented Oct 30, 2025 •

edited

Loading