Skip to content

[di] Expose a detached MeterProviderBuilder extension on IServiceCollection which may modify services#4517

Merged
CodeBlanch merged 10 commits intoopen-telemetry:mainfrom
CodeBlanch:di-configuremetrics-withservices
May 31, 2023
Merged

[di] Expose a detached MeterProviderBuilder extension on IServiceCollection which may modify services#4517
CodeBlanch merged 10 commits intoopen-telemetry:mainfrom
CodeBlanch:di-configuremetrics-withservices

Conversation

@CodeBlanch
Copy link
Copy Markdown
Member

@CodeBlanch CodeBlanch commented May 25, 2023

Relates to #4508

Changes

  • Adds an overload to the IServiceCollection.ConfigureOpenTelemetryMeterProvider extension which doesn't require IServiceProvider and allows for IServiceCollection modification.

Public API Changes

namespace OpenTelemetry.Trace
{
   public static class OpenTelemetryDependencyInjectionMetricsServiceCollectionExtensions
   {
+     public static IServiceCollection ConfigureOpenTelemetryMeterProvider(this IServiceCollection services, Action<MeterProviderBuilder> configure) {}
   }
}

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team May 25, 2023 17:40
@codecov
Copy link
Copy Markdown

codecov bot commented May 25, 2023

Codecov Report

Merging #4517 (4283bb0) into main (e85bd93) will increase coverage by 0.11%.
The diff coverage is 98.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4517      +/-   ##
==========================================
+ Coverage   85.20%   85.32%   +0.11%     
==========================================
  Files         318      319       +1     
  Lines       12620    12634      +14     
==========================================
+ Hits        10753    10780      +27     
+ Misses       1867     1854      -13     
Impacted Files Coverage Δ
...encyInjectionTracingServiceCollectionExtensions.cs 100.00% <ø> (ø)
...s/Metrics/MeterProviderServiceCollectionBuilder.cs 96.66% <96.66%> (ø)
...encyInjectionMetricsServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...emetry/Metrics/Builder/MeterProviderBuilderBase.cs 97.22% <100.00%> (+2.57%) ⬆️
...lemetry/Trace/Builder/TracerProviderBuilderBase.cs 98.07% <100.00%> (+26.07%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants