-
Notifications
You must be signed in to change notification settings - Fork 882
Prometheus Exporter - New .MapPrometheusScrapingEndpoint() Extension Method #3295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cijothomas
merged 14 commits into
open-telemetry:main
from
hannahchan:MapPrometheusScrapingEndpoint
Jun 7, 2022
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7529346
Spike
hannahchan b6af4dd
Revision
hannahchan 412c95b
Revision
hannahchan 86ae8a4
Add Unit Tests
hannahchan 33d9f22
Add overloads and improved documentation comments
hannahchan 9b08975
Add null guard
hannahchan 44446c0
Switch to `endpoints.ServiceProvider`
hannahchan 721ff33
Update Change Log and PublicAPI
hannahchan edd9944
Merge branch 'main' into MapPrometheusScrapingEndpoint
hannahchan 49266e4
Merge branch 'main' into MapPrometheusScrapingEndpoint
hannahchan a9a8734
Merge branch 'main' into MapPrometheusScrapingEndpoint
hannahchan c623786
Fix PublicAPI.Unshipped.txt
hannahchan 4474ca5
Merge branch 'main' into MapPrometheusScrapingEndpoint
hannahchan 8932781
Merge branch 'main' into MapPrometheusScrapingEndpoint
cijothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
112 changes: 112 additions & 0 deletions
112
src/OpenTelemetry.Exporter.Prometheus/PrometheusExporterEndpointRouteBuilderExtensions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| // <copyright file="PrometheusExporterEndpointRouteBuilderExtensions.cs" company="OpenTelemetry Authors"> | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // </copyright> | ||
|
|
||
| #if NETCOREAPP3_1_OR_GREATER | ||
|
|
||
| using System; | ||
| using Microsoft.AspNetCore.Http; | ||
| using Microsoft.AspNetCore.Routing; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using OpenTelemetry.Exporter; | ||
| using OpenTelemetry.Exporter.Prometheus; | ||
| using OpenTelemetry.Internal; | ||
| using OpenTelemetry.Metrics; | ||
|
|
||
| namespace Microsoft.AspNetCore.Builder | ||
| { | ||
| /// <summary> | ||
| /// Provides extension methods for <see cref="IEndpointRouteBuilder"/> to add | ||
| /// Prometheus scraping endpoint. | ||
| /// </summary> | ||
| public static class PrometheusExporterEndpointRouteBuilderExtensions | ||
| { | ||
| /// <summary> | ||
| /// Adds OpenTelemetry Prometheus scraping endpoint middleware to an | ||
| /// <see cref="IEndpointRouteBuilder"/> instance. | ||
| /// </summary> | ||
| /// <remarks>Note: A branched pipeline is created for the route | ||
| /// specified by <see | ||
| /// cref="PrometheusExporterOptions.ScrapeEndpointPath"/>.</remarks> | ||
| /// <param name="endpoints">The <see cref="IEndpointRouteBuilder"/> to add | ||
| /// middleware to.</param> | ||
| /// <returns>A convention routes for the Prometheus scraping endpoint.</returns> | ||
| public static IEndpointConventionBuilder MapPrometheusScrapingEndpoint(this IEndpointRouteBuilder endpoints) | ||
| => MapPrometheusScrapingEndpoint(endpoints, path: null, meterProvider: null, configureBranchedPipeline: null); | ||
|
|
||
| /// <summary> | ||
| /// Adds OpenTelemetry Prometheus scraping endpoint middleware to an | ||
| /// <see cref="IEndpointRouteBuilder"/> instance. | ||
| /// </summary> | ||
| /// <param name="endpoints">The <see cref="IEndpointRouteBuilder"/> to add | ||
| /// middleware to.</param> | ||
| /// <param name="path">The path to use for the branched pipeline.</param> | ||
| /// <returns>A convention routes for the Prometheus scraping endpoint.</returns> | ||
| public static IEndpointConventionBuilder MapPrometheusScrapingEndpoint(this IEndpointRouteBuilder endpoints, string path) | ||
| { | ||
| Guard.ThrowIfNull(path); | ||
| return MapPrometheusScrapingEndpoint(endpoints, path, meterProvider: null, configureBranchedPipeline: null); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Adds OpenTelemetry Prometheus scraping endpoint middleware to an | ||
| /// <see cref="IEndpointRouteBuilder"/> instance. | ||
| /// </summary> | ||
| /// <param name="endpoints">The <see cref="IEndpointRouteBuilder"/> to add | ||
| /// middleware to.</param> | ||
| /// <param name="path">Optional path to use for the branched pipeline. | ||
| /// If not provided then <see cref="PrometheusExporterOptions.ScrapeEndpointPath"/> | ||
| /// is used.</param> | ||
| /// <param name="meterProvider">Optional <see cref="MeterProvider"/> | ||
| /// containing a <see cref="PrometheusExporter"/> otherwise the primary | ||
| /// SDK provider will be resolved using application services.</param> | ||
| /// <param name="configureBranchedPipeline">Optional callback to | ||
| /// configure the branched pipeline. Called before registration of the | ||
| /// Prometheus middleware.</param> | ||
| /// <returns>A convention routes for the Prometheus scraping endpoint.</returns> | ||
| public static IEndpointConventionBuilder MapPrometheusScrapingEndpoint( | ||
| this IEndpointRouteBuilder endpoints, | ||
| string path = null, | ||
| MeterProvider meterProvider = null, | ||
| Action<IApplicationBuilder> configureBranchedPipeline = null) | ||
| { | ||
| var builder = endpoints.CreateApplicationBuilder(); | ||
|
|
||
| // Note: Order is important here. MeterProvider is accessed before | ||
| // GetOptions<PrometheusExporterOptions> so that any changes made to | ||
| // PrometheusExporterOptions in deferred AddPrometheusExporter | ||
| // configure actions are reflected. | ||
| meterProvider ??= builder.ApplicationServices.GetRequiredService<MeterProvider>(); | ||
hannahchan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| if (path == null) | ||
| { | ||
| var options = builder.ApplicationServices.GetOptions<PrometheusExporterOptions>(); | ||
| path = options.ScrapeEndpointPath ?? PrometheusExporterOptions.DefaultScrapeEndpointPath; | ||
| } | ||
|
|
||
| if (!path.StartsWith("/")) | ||
| { | ||
| path = $"/{path}"; | ||
| } | ||
|
|
||
| configureBranchedPipeline?.Invoke(builder); | ||
|
|
||
| builder.UseMiddleware<PrometheusExporterMiddleware>(meterProvider); | ||
|
|
||
| return endpoints.Map(new PathString(path), builder.Build()); | ||
| } | ||
| } | ||
| } | ||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.