Prometheus Exporter - New .MapPrometheusScrapingEndpoint() Extension Method#3295
Merged
cijothomas merged 14 commits intoopen-telemetry:mainfrom Jun 7, 2022
hannahchan:MapPrometheusScrapingEndpoint
Merged
Prometheus Exporter - New .MapPrometheusScrapingEndpoint() Extension Method#3295cijothomas merged 14 commits intoopen-telemetry:mainfrom hannahchan:MapPrometheusScrapingEndpoint
cijothomas merged 14 commits intoopen-telemetry:mainfrom
hannahchan:MapPrometheusScrapingEndpoint
Conversation
CodeBlanch
reviewed
May 23, 2022
src/OpenTelemetry.Exporter.Prometheus/PrometheusExporterEndpointRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
May 23, 2022
src/OpenTelemetry.Exporter.Prometheus/PrometheusExporterEndpointRouteBuilderExtensions.cs
Show resolved
Hide resolved
Member
|
@tillig If you have time would you mind also doing a review of this? |
Codecov Report
@@ Coverage Diff @@
## main #3295 +/- ##
=======================================
Coverage ? 85.72%
=======================================
Files ? 267
Lines ? 9383
Branches ? 0
=======================================
Hits ? 8044
Misses ? 1339
Partials ? 0
|
tillig
reviewed
May 25, 2022
src/OpenTelemetry.Exporter.Prometheus/PrometheusExporterEndpointRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Just one comment about where services get resolved from, otherwise LGTM. |
Member
|
@hannahchan could you fix the conflicts? |
Contributor
Author
|
@cijothomas Yep done. Please let me know if you need anything else. |
Contributor
Author
|
Hi all, The build failed and I think I've just fixed the issues I had with Side note, the code fixes for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3267
Changes
Adds a new extension method
MapPrometheusScrapingEndpoint()that extends offIEndpointRouteBuilderinstead ofIApplicationBuilderand returns anIEndpointConventionBuilderfor chaining.Please squash merge.