Conversation
1 task
1 task
Member
Author
|
This is blocking the OpenAPI updates downstream. It would be helpful to get this merged ASAP to fix octokit/plugin-paginate-rest.js#521 and probably others |
nickfloyd
approved these changes
Apr 27, 2023
nickfloyd
left a comment
Contributor
There was a problem hiding this comment.
Solid work here @wolfy1339! From what I can tell this shouldn't impact those cases where the requestBody can be empty, but let me know if I am off there. Thank you so much for handling this for our community! ❤️
Contributor
|
🎉 This PR is included in version 9.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Resolves #528
Behavior
Before the change?
ExtractRequestBody<T>type would potentially returnneversince therequestBodywas potentiallyundefinedAfter the change?
ExtractRequestBody<T>Other information
openapi-typescriptv6Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug