fix(types): make all parameters in types required for ExtractRequestBody<T> (#529)

wolfy1339 · web-flow · commit 0d84b4d00c72 · 2023-04-27T15:02:11.000-04:00
Fixes #528
diff --git a/scripts/update-endpoints/templates/endpoints.ts.template b/scripts/update-endpoints/templates/endpoints.ts.template
@@ -35,7 +35,7 @@ type ExtractRequestBody<T> = "requestBody" extends keyof T
         }[keyof T["requestBody"]];
       }
   : {};
-type ToOctokitParameters<T> = ExtractParameters<T> & ExtractRequestBody<T>;
+type ToOctokitParameters<T> = ExtractParameters<T> & ExtractRequestBody<Required<T>>;
 
 type RequiredPreview<T> = T extends string
   ? {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ type ExtractRequestBody<T> = "requestBody" extends keyof T`
`35`	`35`	`}[keyof T["requestBody"]];`
`36`	`36`	`}`
`37`	`37`	`: {};`
`38`		`-type ToOctokitParameters<T> = ExtractParameters<T> & ExtractRequestBody<T>;`
	`38`	`+type ToOctokitParameters<T> = ExtractParameters<T> & ExtractRequestBody<Required<T>>;`
`39`	`39`
`40`	`40`	`type RequiredPreview<T> = T extends string`
`41`	`41`	`? {`