feat: add all bundled otel config to the observe-agent binary instead of relying on files on disk #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
obs-gh-mattcotter
force-pushed
the
OB-42646-bundle-observe-config-in-binary
branch
from
a17a1bf to
a9a8a4a
Compare
obs-gh-mattcotter
force-pushed
the
OB-42646-bundle-observe-config-in-binary
branch
from
a9a8a4a to
ab87d83
Compare
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
obs-gh-alexlew
approved these changes
Jul 2, 2025
… of relying on files on disk
obs-gh-mattcotter
force-pushed
the
OB-42646-bundle-observe-config-in-binary
branch
from
ab87d83 to
35411ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OB-42646 Add all bundled OTel config to the
observe-agentbinary instead of relying on files on disk.This will make it easier for support / our users to download releases directly off of github and work out of the box. It also makes management easier on our side and removes possible confusions from our users about the extra files on disk that we install.
While I was here, I de-duplicated as many configs as possible. I left a few
TODOs because I wanted to leave all snapshot tests untouched, but I plan to do a follow up and reuse even more config across our platforms.Stats
67 files changed, 311 insertions(+), 797 deletions(-)big diff, but an overall reduction in lines and lots of deleting duplicate files.