Skip to content

feat: tune memory limiter settings #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

feat: tune memory limiter settings #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
450d6fc
feat: tune memory limiter settings
obs-gh-alexlew Feb 6, 2025
6fc8a82
Merge branch 'main' into alew/tune-memory-limiter
obs-gh-alexlew Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packaging/docker/observe-agent/otel-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ processors:

memory_limiter:
check_interval: 1s
limit_percentage: 20
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had misinterpreted the meaning of these fields. limit_percentage is the total possible usage allowed to this pipeline and after that it starts dropping data. I think maybe we thought that it wasn't a shared thing but actually each instance of this component has a shared size limit so if we only have one instance of this component then its safe to use up to 80% of memory total. The spike percentage is basically reserved for spikes so generally the process is actually limited to 60% of memory and is allowed to spike up to 80.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense! So do you think we should omit this when running on bare metal? Maybe we could put a comment about that in our docs if so.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure how the max gets calculated in a bare-metal situation since it doesn't technically exist. maybe there's a gomemlimit default? in which case i dont think its unreasonable to have this limiter try to respect that

spike_limit_percentage: 5
limit_percentage: 80
spike_limit_percentage: 20

batch:

Expand Down
4 changes: 2 additions & 2 deletions packaging/linux/etc/observe-agent/otel-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ processors:

memory_limiter:
check_interval: 1s
limit_percentage: 20
spike_limit_percentage: 5
limit_percentage: 80
spike_limit_percentage: 20

batch:

Expand Down
4 changes: 2 additions & 2 deletions packaging/macos/config/otel-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ processors:

memory_limiter:
check_interval: 1s
limit_percentage: 20
spike_limit_percentage: 5
limit_percentage: 80
spike_limit_percentage: 20

batch:

Expand Down
4 changes: 2 additions & 2 deletions packaging/windows/config/otel-collector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ processors:

memory_limiter:
check_interval: 1s
limit_percentage: 20
spike_limit_percentage: 5
limit_percentage: 80
spike_limit_percentage: 20

batch:

Expand Down
Loading