feat: tune memory limiter settings #161
Conversation
| @@ -33,8 +33,8 @@ processors: | |||
|
|
|||
| memory_limiter: | |||
| check_interval: 1s | |||
| limit_percentage: 20 | |||
There was a problem hiding this comment.
I think we had misinterpreted the meaning of these fields. limit_percentage is the total possible usage allowed to this pipeline and after that it starts dropping data. I think maybe we thought that it wasn't a shared thing but actually each instance of this component has a shared size limit so if we only have one instance of this component then its safe to use up to 80% of memory total. The spike percentage is basically reserved for spikes so generally the process is actually limited to 60% of memory and is allowed to spike up to 80.
There was a problem hiding this comment.
Nice, makes sense! So do you think we should omit this when running on bare metal? Maybe we could put a comment about that in our docs if so.
There was a problem hiding this comment.
im not sure how the max gets calculated in a bare-metal situation since it doesn't technically exist. maybe there's a gomemlimit default? in which case i dont think its unreasonable to have this limiter try to respect that
| @@ -33,8 +33,8 @@ processors: | |||
|
|
|||
| memory_limiter: | |||
| check_interval: 1s | |||
| limit_percentage: 20 | |||
There was a problem hiding this comment.
Nice, makes sense! So do you think we should omit this when running on bare metal? Maybe we could put a comment about that in our docs if so.
Description
OB-XXX Please explain the changes you made here.
Checklist