Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 16, 2024

This PR targets on release-1.3 branch.

JeyJeyGao and others added 3 commits December 16, 2024 13:09
Fix:
- permission for `stale` and `license-checker`
- replace tagged version with pinned version for `stale` action

---------

Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
This PR intends to add more unit tests to increase the code coverage.

---------

Signed-off-by: Patrick Zheng <[email protected]>
@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (de974f8) to head (1e838d5).
Report is 4 commits behind head on release-1.3.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.3    #1110      +/-   ##
===============================================
- Coverage        72.00%   70.35%   -1.65%     
===============================================
  Files               46       46              
  Lines             2300     2911     +611     
===============================================
+ Hits              1656     2048     +392     
- Misses             442      670     +228     
+ Partials           202      193       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT changed the title fix: cherry pick from main to release-1.3 branch fix: cherry pick minor fixes from main to release-1.3 Dec 16, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit da0c964 into notaryproject:release-1.3 Dec 17, 2024
7 checks passed
@ghost ghost deleted the cherry-pick branch December 17, 2024 00:16
@ghost ghost mentioned this pull request Dec 30, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants