fix: fix debug log #1061
Merged
fix: fix debug log #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2024 09:01
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Signed-off-by: Patrick Zheng <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 72.00% 72.02% +0.02%
==========================================
Files 46 46
Lines 2300 2302 +2
==========================================
+ Hits 1656 1658 +2
Misses 442 442
Partials 202 202 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
reviewed
Oct 11, 2024
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
requested changes
Oct 11, 2024
Contributor
|
As suggested by Shiwei, ORAS's implementation may be better. |
Signed-off-by: Patrick Zheng <[email protected]>
| logHeader(req.Header, e) | ||
| // log the request | ||
| e.Debugf("Request #%d\n> Request: %q %q\n> Request headers:\n%s", | ||
| id, req.Method, req.URL, logHeader(req.Header)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
shizhMSFT
reviewed
Oct 14, 2024
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
approved these changes
Oct 14, 2024
This was referenced Mar 12, 2025
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Patrick Zheng <[email protected]>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Signed-off-by: Patrick Zheng <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the debug log has issues under multi-thread scenarios. This may cause a request log being followed by a response log of another request, which is confusing for log readers.
This PR fixes the issue by labeling the request and response pairs.
This PR does not change any log content. It only makes the log more readable.