http, benchmark: remove CRLF variables

[wlgh1553]

This PR replaces remaining usages of the CRLF variable with the string literal\r\n and removes theCRLF export from _http_common.js.

Background

In #40101, it was discussed that using the string literal \r\n is clearer and more explicit than using a CRLF variable. Based on this consensus, this PR replaces all remaining usages of the CRLF variable with the \r\n literal.

About removing the export

Previously, there was a TODO comment not to remove the CRLF export from _http_common.js because the module was considered "semi-public" and should not have breaking changes without proper deprecation (discussion).

However, as of #59293, the _http_common.js module (along with other node:_http_* modules) is now officially deprecated and considered internal-only:

Given this, I considered it appropriate to remove the CRLF export.

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net
• @nodejs/performance

[mcollina]

lgtm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.88%. Comparing base (f7a2ba7) to head (eff20f7).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59466      +/-   ##
==========================================
- Coverage   89.88%   89.88%   -0.01%     
==========================================
  Files         656      656              
  Lines      192963   192963              
  Branches    37845    37850       +5     
==========================================
- Hits       173448   173443       -5     
+ Misses      12049    12046       -3     
- Partials     7466     7474       +8     

see 42 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68619/

[richardlau]

About removing the export

Previously, there was a TODO comment not to remove the CRLF export from _http_common.js because the module was considered "semi-public" and should not have breaking changes without proper deprecation (discussion).

However, as of #59293, the _http_common.js module (along with other node:_http_* modules) is now officially deprecated and considered internal-only:

Given this, I considered it appropriate to remove the CRLF export.

The node:_http_* modules are only documentation deprecated. We can't remove the functionality until End-of-Life deprecation.

[richardlau]

#59466 (comment)

We should not remove the export until End-of-Life deprecation.

[wlgh1553]

#59466 (comment)

We should not remove the export until End-of-Life deprecation.

Thanks for the review! Based on your feedback, I've added a commit to restore the CRLF export. eff20f7

Concern has been addressed

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68660/