2025-06-24, Version 24.3.0 (Current) #58804
Closed
+13,821
−4,160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PR-URL: #58604 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #58614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #58615 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58438 Fixes: #58322 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #58625 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #58628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #58629 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #58630 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #58633 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #58580 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #58567 Fixes: #58562 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #58610 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
PR-URL: #58490 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #58639 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>
PR-URL: #58640 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Split indirect eval import tests as they depends on the JS stack to resolve the referrer. PR-URL: #58637 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
When --import is used, the ESM loader is used to handle even pure CJS entry points, and it can run into CJS module facades in the evaluating state when the parent CJS module is being evaluated. In this case it should be allowed, since the ESM <-> CJS cycles that are meant to be disallowed (for the time being) should already be detected before evaluation and wouldn't get here, and CJS <-> CJS cycles are fine. PR-URL: #58598 Fixes: #58515 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
PR-URL: #58643 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #58644 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58537 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #58602 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #58669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #58647 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Xuguang Mei <[email protected]>
Added serialization and deserialization support for `DOMException`. Co-Authored-By: jazelly <[email protected]> PR-URL: #58649 Fixes: #49181 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #57419 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #58655 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This commit refactors the CommonJS loader to remove TypeScript-specific extensions from the require.extensions object for compatibility with libraries that depended on it to initialize extenal TypeScript loaders. PR-URL: #58657 Refs: nodejs/typescript#37 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Xuguang Mei <[email protected]>
PR-URL: #58661 Fixes: #58660 Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #58667 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #58599 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Co-Authored-By: Kenta Moriuchi <[email protected]> PR-URL: #58691 Fixes: #56497 Refs: v8/v8@e3df60f Refs: #58138 Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]>
This commit enhances the permission model errors when no --allow-child-process is used and the error is emitted. Signed-off-by: RafaelGSS <[email protected]> PR-URL: #58758 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
The comment in the test file stated that: "SIMD is not supported on rhel8-ppc64le" This is incorrect -- WASM SIMD support is dependent on the available instructions, not the operating system. So it is more correct to say that WASM SIMD is not supported on IBM Power8 architecture. PR-URL: #58767 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
FancyURLopener and URLopener have been deprecated since Python 3.3 and they are removed completely from 3.14. Fixes: #58740 PR-URL: #58752 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use the error message as another condition to skip the test when the buffer allocation fails. Refs: #58738 PR-URL: #58771 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]>
refactor the test/parallel/test-repl-save-load.js file by:
- making the tests in the file self-contained
(instead of all of them sharing the same REPL instance and
constantly calling `.clear` on it)
- clearly separating and commenting the various tests to make
clearer what is being tested
PR-URL: #58715
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #58653 Fixes: #58641 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This reverts commit aa3523e. PR-URL: #58282 Fixes: #58227 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
This reverts commit 9671826. PR-URL: #58282 Fixes: #58227 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
This reverts commit 1a2eb15. PR-URL: #58282 Fixes: #58227 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #58282 Fixes: #58227 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Notable changes: doc: * add islandryu to collaborators (Shima Ryuhei) #58714 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #58643 test_runner: * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 PR-URL: #58804
github-actions
bot
added
the
v24.x
|
Review requested:
|
RafaelGSS
added
request-ci
This should be highlighted in notable changes IMO |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v24.x #58804 +/- ##
==========================================
- Coverage 90.15% 89.57% -0.58%
==========================================
Files 635 637 +2
Lines 188278 188645 +367
Branches 36941 36676 -265
==========================================
- Hits 169742 168979 -763
- Misses 11280 12346 +1066
- Partials 7256 7320 +64 🚀 New features to boost your workflow:
|
|
Is there any chance of merging and adding #58711 here? This is needed to unblock |
|
To minimize any potential breakage for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-06-24, Version 24.3.0 (Current), @RafaelGSS
Notable Changes
841609ac1c] - doc: add islandryu to collaborators (Shima Ryuhei) #58714839964ece8] - (SEMVER-MINOR) fs: allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #584909b28f40834] - (SEMVER-MINOR) module: remove experimental warning from type stripping (Marco Ippolito) #58643713fbad7b6] - (SEMVER-MINOR) test_runner: support object property mocking (Idan Goshen) #58438ef0230abaf] - (SEMVER-MINOR) url: add fileURLToPathBuffer API (James M Snell) #58700Commits
4b61f10eb6] - deps: V8: cherry-pick e3df60f3f5ab (Chengzhong Wu) #58691fa6854f083] - deps: update amaro to 1.1.0 (Node.js GitHub Bot) #5875468671f4314] - deps: upgrade npm to 11.4.2 (npm team) #58696450f4815b3] - deps: update amaro to 1.0.0 (Node.js GitHub Bot) #586393aa2762e96] - deps: update sqlite to 3.50.1 (Node.js GitHub Bot) #5863080eac147e6] - deps: update simdjson to 3.13.0 (Node.js GitHub Bot) #58629dc1023878c] - deps: update zlib to 1.3.1-470d3a2 (Node.js GitHub Bot) #58628e2e88d4971] - doc: fix wrong RFC number in http2 (Deokjin Kim) #587537bb1246c8f] - doc: add history entry for TS support in hooks (Antoine du Hamel) #58732f125310d3a] - doc: run license-builder (github-actions[bot]) #58722841609ac1c] - doc: add islandryu to collaborators (Shima Ryuhei) #587141cc77c7ee6] - doc: punctuation fix for Node-API versioning clarification (Jiacai Liu) #58599d59680348e] - doc: add path rules and validation for export targets in package.json (0hm☘️) #58604b6760b3379] - esm: syncify default path ofModuleLoader.load(Jacob Smith) #5741996c78d726c] - fs: makeDirdisposers idempotent (René) #5869262b5879d88] - fs: avoid computing time coefficient constants in runtime (Livia Medeiros) #58728af18c0e81a] - fs: remove IIFE in glob (LiviaMedeiros) #58418fb4378b72e] - fs: add UV_ENOSPC to list of things to pass to err directly (Jacky Zhao) #56918839964ece8] - (SEMVER-MINOR) fs: allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490b11da1115e] - http2: fix DEP0194 message (KaKa) #58669b1f60d2f18] - http2: add diagnostics channel 'http2.server.stream.close' (Darshan Sen) #58602be93091694] - inspector: add protocol methods retrieving sent/received data (Chengzhong Wu) #58645081c70878f] - lib: make domexception a native error (Chengzhong Wu) #586916390f70da2] - lib,src: support DOMException ser-des (Chengzhong Wu) #58649ff8a3691c4] - module: fix typescript import.meta.main (Marco Ippolito) #5866145f7d160ed] - module: refactor commonjs typescript loader (Marco Ippolito) #586579b28f40834] - (SEMVER-MINOR) module: remove experimental warning from type stripping (Marco Ippolito) #58643a3c7a63c73] - module: allow cycles in require() in the CJS handling in ESM loader (Joyee Cheung) #58598d0e42ffa58] - repl: avoid deprecatedrequire.extensionsin tab completion (baki gul) #5865382b18ba890] - repl: fix tab completion not working with computer string properties (Dario Piotrowicz) #58709a0b1378a20] - src: pass resource on permission checks for spawn (Rafael Gonzaga) #58758dfb0144490] - src: enhance error messages for unknown options (Pietro Marchini) #58677e9c6fa514c] - src: replace std::array with static arrays in contextify (Mert Can Altin) #585804347ce3dba] - src: add new CopyUtimes function to reduce code duplication (Dario Piotrowicz) #58625893999e0ee] - src: replace V8 Fast API todo comment with note comment (Dario Piotrowicz) #586147cdda927fa] - test: fix test-timeout-flag after revert of auto subtest wait (Pietro Marchini) #58282d9c2b7054b] - test: refactor repl save-load tests (Dario Piotrowicz) #587153faa4e8b56] - test: deflake test-buffer-large-size-buffer-alloc-unsafe (Luigi Pinca) #587718eec789888] - test: correct SIMD support comment (Richard Lau) #587676e0ee39b6d] - test: skip the test if the buffer allocation fails (Luigi Pinca) #58738d94b184700] - test: deflake test-buffer-large-size-buffer-alloc (Luigi Pinca) #58734704b1fa075] - test: add tests for REPL custom evals (Dario Piotrowicz) #57850c39d570871] - test: reduce the use of private symbols in test-events-once.js (Yoshiya Hinosawa) #58685b7e488c77f] - test: refactor repl tab complete tests (Dario Piotrowicz) #58636ec808b3e06] - test: usecommon.skipIfInspectorDisabled()to skip tests (Dario Piotrowicz) #5867594e53d4f6c] - test: update WPT for urlpattern to 3ffda23e5a (Node.js GitHub Bot) #58537fa089d610f] - test: update WPT for dom/abort to dc928169ee (Node.js GitHub Bot) #58644aa657f0fc4] - test: split indirect eval import tests (Chengzhong Wu) #5863776e3c8aaf2] - test: update WPT for es-exceptions to 2f96fa1996 (Node.js GitHub Bot) #586407e34aa4eaa] - test: skip tests failing when run under root (Livia Medeiros) #5861085f062c22e] - test: deflake async-hooks/test-improper-order on AIX (Baki Gul) #58567181014a8fe] - test: cleanup status files (Filip Skokan) #58633a4d756068d] - test: close FileHandle objects in tests explicitly (James M Snell) #58615dce1995c55] - Revert "test_runner: remove promises returned by t.test()" (Romain Menke) #582828b0c5edbb6] - Revert "test_runner: remove promises returned by test()" (Romain Menke) #582826ef7329c8c] - Revert "test_runner: automatically wait for subtests to finish" (Romain Menke) #58282c9e7b5e43a] - test_runner: preferAtomicsprimordials (Renegade334) #58716713fbad7b6] - (SEMVER-MINOR) test_runner: support object property mocking (Idan Goshen) #584389df1cfe402] - tools: make nodedownload module compatible with Python 3.14 (Lumír 'Frenzy' Balhar) #58752b5ff3f42b8] - tools: include toolchain.gypi in abseil.gyp (Chengzhong Wu) #58678dc2f23e986] - tools: bumpbrace-expansionin/tools/clang-format(dependabot[bot]) #58699e6a1787140] - tools: bump brace-expansion from 1.1.11 to 1.1.12 in /tools/eslint (dependabot[bot]) #58698b22e970774] - tools: switch to@stylistic/eslint-plugin(Michaël Zasso) #58623268c8c1799] - tools: remove config.status undermake distclean(René) #58603c1f9791844] - tools: edit commit-queue workflow file (Antoine du Hamel) #58667afbaf9277b] - tools: improve release proposal linter (Antoine du Hamel) #5864717df800b90] - typings: add Atomics primordials (Renegade334) #58577ffff8ce3a4] - typings: add ZSTD_COMPRESS, ZSTD_DECOMPRESS to internalBinding (Meghan Denny) #58655ef0230abaf] - (SEMVER-MINOR) url: add fileURLToPathBuffer API (James M Snell) #587006f7b89516f] - util: inspect: do not crash on an Error stack pointing to itself (Sam Verschueren) #58196