module: remove experimental warning from type stripping #58643

marco-ippolito · 2025-06-09T10:03:43Z

Type Stripping is quite stable, I think it's time to remove the experimental warning to make it less noisy.
(It's still experimental release candidate)
--experimental-transform-types will still emit the experimental warning.

nodejs-github-bot · 2025-06-09T10:03:48Z

Review requested:

@nodejs/loaders
@nodejs/typescript

codecov · 2025-06-09T11:11:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (b23648e) to head (902551a).
Report is 152 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58643   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         636      636           
  Lines      187891   187883    -8     
  Branches    36879    36872    -7     
=======================================
- Hits       169386   169385    -1     
+ Misses      11272    11241   -31     
- Partials     7233     7257   +24

Files with missing lines	Coverage Δ
lib/internal/modules/typescript.js	`97.47% <100.00%> (-0.04%)`	⬇️
lib/internal/process/execution.js	`94.33% <100.00%> (-0.48%)`	⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

lgtm

nodejs-github-bot · 2025-06-09T11:59:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67356/

nodejs-github-bot · 2025-06-09T14:51:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67363/

github-actions · 2025-06-10T08:46:46Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @mcollina.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot · 2025-06-11T10:12:06Z

Landed in 6584d5f

PR-URL: #58643 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

Notable changes: doc: * add islandryu to collaborators (Shima Ryuhei) #58714 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #58643 test_runner: * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 PR-URL: #58727

Notable changes: doc: * add islandryu to collaborators (Shima Ryuhei) #58714 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #58643 test_runner: * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 PR-URL: #58804

Notable changes: doc: * add islandryu to collaborators (Shima Ryuhei) #58714 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #58643 test: * fix test-timeout-flag after revert of auto subtest wait (Pietro Marchini) #58282 test_runner: * Revert "test_runner: remove promises returned by t.test() (Romain Menke) #58282 * Revert "test_runner: remove promises returned by test() (Romain Menke) #58282 * Revert "test_runner: automatically wait for subtests to finish (Romain Menke) #58282 * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 PR-URL: #58813

Notable changes: doc: * add islandryu to collaborators (Shima Ryuhei) #58714 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #58643 test: * fix test-timeout-flag after revert of auto subtest wait (Pietro Marchini) #58282 test_runner: * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 PR-URL: #58813

PR-URL: nodejs#58643 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: #58643 Backport-PR-URL: #57298 Refs: nodejs/typescript#24 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> PR-URL: #56350 Fixes: nodejs/typescript#17

nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jun 9, 2025

marco-ippolito force-pushed the remove-experimental-warning-type-stripping branch from cee6638 to 2fa1ad1 Compare June 9, 2025 10:04

marco-ippolito marked this pull request as ready for review June 9, 2025 10:04

marco-ippolito added semver-minor PRs that contain new features and should be released in the next minor version. strip-types Issues or PRs related to strip-types support labels Jun 9, 2025

JakobJingleheimer approved these changes Jun 9, 2025

View reviewed changes

targos approved these changes Jun 9, 2025

View reviewed changes

module: remove experimental warning from type stripping

902551a

marco-ippolito force-pushed the remove-experimental-warning-type-stripping branch from 2fa1ad1 to 902551a Compare June 9, 2025 10:12

mcollina approved these changes Jun 9, 2025

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 9, 2025

ljharb approved these changes Jun 9, 2025

View reviewed changes

jasnell approved these changes Jun 9, 2025

View reviewed changes

panva approved these changes Jun 9, 2025

View reviewed changes

Ethan-Arrowood approved these changes Jun 9, 2025

View reviewed changes

trivikr approved these changes Jun 10, 2025

View reviewed changes

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2025

mcollina added the notable-change PRs with changes that should be highlighted in changelogs. label Jun 10, 2025

legendecas approved these changes Jun 10, 2025

View reviewed changes

atlowChemi approved these changes Jun 11, 2025

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2025

nodejs-github-bot merged commit 6584d5f into nodejs:main Jun 11, 2025
68 checks passed

JoshuaKGoldberg mentioned this pull request Jun 11, 2025

🛠 Tooling: Migrate eslint.config.js to typescript JoshuaKGoldberg/eslint-plugin-package-json#1099

Closed

3 tasks

This was referenced Jun 16, 2025

🚀 Feature: Switch eslint.config.js to eslint.config.ts JoshuaKGoldberg/create-typescript-app#2225

Open

build: convert eslint.config to typescript and add our plugin JoshuaKGoldberg/eslint-plugin-package-json#1112

Merged

github-actions bot mentioned this pull request Jun 16, 2025

2025-06-17, Version 24.3.0 (Current) #58727

Closed

JoshuaKGoldberg mentioned this pull request Jun 21, 2025

Add support for generating TypeScript configuration files eslint/create-config#177

Closed

1 task

github-actions bot mentioned this pull request Jun 23, 2025

2025-06-24, Version 24.3.0 (Current) #58804

Closed

github-actions bot mentioned this pull request Jun 24, 2025

2025-06-24, Version 24.3.0 (Current) #58813

Merged

marco-ippolito added the backport-open-v22.x Indicate that the PR has an open backport label Jun 25, 2025

thescientist13 mentioned this pull request Jul 1, 2025

[v22.x backport] module: unflag --experimental-strip-types #57298

Closed

marco-ippolito added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Jul 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

module: remove experimental warning from type stripping #58643

module: remove experimental warning from type stripping #58643

marco-ippolito commented Jun 9, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

codecov bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

module: remove experimental warning from type stripping #58643

module: remove experimental warning from type stripping #58643

Conversation

marco-ippolito commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

codecov bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

nodejs-github-bot commented Jun 9, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 11, 2025

Uh oh!

Uh oh!

marco-ippolito commented Jun 9, 2025 •

edited

Loading

codecov bot commented Jun 9, 2025 •

edited

Loading