FIX: Remove default null in schema#1119
Merged
maxulysse merged 3 commits intonf-core:devfrom Jun 20, 2023
Merged
Conversation
10 tasks
|
SusiJo
reviewed
Jun 20, 2023
| "pattern": "^\\S+\\.csv$", | ||
| "schema": "assets/schema_input.json", | ||
| "description": "Path to comma-separated file containing information about the samples in the experiment.", | ||
| "help_text": "A design file with information about the samples in your experiment. Use this parameter to specify the location of the input files. It has to be a comma-separated file with a header row. See [usage docs](https://nf-co.re/sarek/usage#input).\n\nIf no input file is specified, sarek will attempt to locate one in the `{outdir}` directory.", |
Contributor
There was a problem hiding this comment.
Are the two linebreaks here intended or should it just be one linebreak?
Member
Author
There was a problem hiding this comment.
I actually just moved that part around, so never notice the line breaks, so I'd say that yeah, they are intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we have lint for that?